Skip to content

Commit 0683c3f

Browse files
committed
fix
1 parent 3ac2d9f commit 0683c3f

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

opentelemetry-sdk/src/logs/log_emitter.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use super::{BatchLogProcessor, LogProcessor, LogRecord, SimpleLogProcessor, TraceContext};
22
use crate::{export::logs::LogExporter, runtime::RuntimeChannel, Resource};
33
use crate::{logs::LogError, logs::LogResult};
4-
use opentelemetry::{otel_debug, trace::TraceContextExt, Context, InstrumentationScope};
4+
use opentelemetry::{otel_debug, otel_warn, trace::TraceContextExt, Context, InstrumentationScope};
55

66
#[cfg(feature = "spec_unstable_logs_enabled")]
77
use opentelemetry::logs::Severity;
@@ -44,17 +44,14 @@ pub struct LoggerProvider {
4444
inner: Arc<LoggerProviderInner>,
4545
}
4646

47-
/// Default logger name if empty string is provided.
48-
const DEFAULT_COMPONENT_NAME: &str = "rust.opentelemetry.io/sdk/logger";
49-
5047
impl opentelemetry::logs::LoggerProvider for LoggerProvider {
5148
type Logger = Logger;
5249

5350
fn logger(&self, name: impl Into<Cow<'static, str>>) -> Self::Logger {
54-
let mut name = name.into();
51+
let name = name.into();
5552

5653
if name.is_empty() {
57-
name = Cow::Borrowed(DEFAULT_COMPONENT_NAME)
54+
otel_warn!(name: "LoggerProvider.Logger.EmptyName", message = "Logger name is empty; consider providing a meaningful name");
5855
};
5956

6057
let scope = InstrumentationScope::builder(name).build();

0 commit comments

Comments
 (0)