Skip to content

Commit 0902017

Browse files
authored
Merge branch 'main' into more-inttests
2 parents 4ce76df + fdf4a63 commit 0902017

File tree

44 files changed

+103
-90
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+103
-90
lines changed

opentelemetry-appender-log/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ mod tests {
769769
use super::OpenTelemetryLogBridge;
770770

771771
use opentelemetry::{logs::AnyValue, StringValue};
772-
use opentelemetry_sdk::{logs::LoggerProvider, testing::logs::InMemoryLogExporter};
772+
use opentelemetry_sdk::{logs::InMemoryLogExporter, logs::LoggerProvider};
773773

774774
use log::Log;
775775

opentelemetry-appender-tracing/src/layer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,9 @@ mod tests {
213213
use opentelemetry::trace::TracerProvider as _;
214214
use opentelemetry::trace::{TraceContextExt, TraceFlags, Tracer};
215215
use opentelemetry::{logs::AnyValue, Key};
216+
use opentelemetry_sdk::logs::InMemoryLogExporter;
216217
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
217218
use opentelemetry_sdk::logs::{LogRecord, LogResult, LoggerProvider};
218-
use opentelemetry_sdk::testing::logs::InMemoryLogExporter;
219219
use opentelemetry_sdk::trace::{Sampler, TracerProvider};
220220
use tracing::{error, warn};
221221
use tracing_subscriber::prelude::__tracing_subscriber_SubscriberExt;

opentelemetry-otlp/src/exporter/http/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ use opentelemetry_proto::transform::common::tonic::ResourceAttributesWithSchema;
1313
use opentelemetry_proto::transform::logs::tonic::group_logs_by_resource_and_scope;
1414
#[cfg(feature = "trace")]
1515
use opentelemetry_proto::transform::trace::tonic::group_spans_by_resource_and_scope;
16-
#[cfg(feature = "trace")]
17-
use opentelemetry_sdk::export::trace::SpanData;
1816
#[cfg(feature = "logs")]
1917
use opentelemetry_sdk::logs::LogBatch;
18+
#[cfg(feature = "trace")]
19+
use opentelemetry_sdk::trace::SpanData;
2020
use prost::Message;
2121
use std::collections::HashMap;
2222
use std::env;

opentelemetry-otlp/src/exporter/http/trace.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::sync::Arc;
33
use futures_core::future::BoxFuture;
44
use http::{header::CONTENT_TYPE, Method};
55
use opentelemetry::{otel_debug, trace::TraceError};
6-
use opentelemetry_sdk::export::trace::{ExportResult, SpanData, SpanExporter};
6+
use opentelemetry_sdk::trace::{ExportResult, SpanData, SpanExporter};
77

88
use super::OtlpHttpClient;
99

opentelemetry-otlp/src/exporter/tonic/trace.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use opentelemetry::{otel_debug, trace::TraceError};
55
use opentelemetry_proto::tonic::collector::trace::v1::{
66
trace_service_client::TraceServiceClient, ExportTraceServiceRequest,
77
};
8-
use opentelemetry_sdk::export::trace::{ExportResult, SpanData, SpanExporter};
8+
use opentelemetry_sdk::trace::{ExportResult, SpanData, SpanExporter};
99
use tonic::{codegen::CompressionEncoding, service::Interceptor, transport::Channel, Request};
1010

1111
use opentelemetry_proto::transform::trace::tonic::group_spans_by_resource_and_scope;

opentelemetry-otlp/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ pub use crate::exporter::{
262262
OTEL_EXPORTER_OTLP_TIMEOUT_DEFAULT,
263263
};
264264

265-
use opentelemetry_sdk::export::ExportError;
265+
use opentelemetry_sdk::ExportError;
266266

267267
/// Type to indicate the builder does not have a client set.
268268
#[derive(Debug, Default, Clone)]

opentelemetry-otlp/src/span.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use std::fmt::Debug;
66

77
use futures_core::future::BoxFuture;
8-
use opentelemetry_sdk::export::trace::{ExportResult, SpanData};
8+
use opentelemetry_sdk::trace::{ExportResult, SpanData};
99

1010
#[cfg(feature = "grpc-tonic")]
1111
use crate::{
@@ -107,7 +107,7 @@ impl HasHttpConfig for SpanExporterBuilder<HttpExporterBuilderSet> {
107107

108108
/// OTLP exporter that sends tracing information
109109
#[derive(Debug)]
110-
pub struct SpanExporter(Box<dyn opentelemetry_sdk::export::trace::SpanExporter>);
110+
pub struct SpanExporter(Box<dyn opentelemetry_sdk::trace::SpanExporter>);
111111

112112
impl SpanExporter {
113113
/// Obtain a builder to configure a [SpanExporter].
@@ -116,12 +116,12 @@ impl SpanExporter {
116116
}
117117

118118
/// Build a new span exporter from a client
119-
pub fn new(client: impl opentelemetry_sdk::export::trace::SpanExporter + 'static) -> Self {
119+
pub fn new(client: impl opentelemetry_sdk::trace::SpanExporter + 'static) -> Self {
120120
SpanExporter(Box::new(client))
121121
}
122122
}
123123

124-
impl opentelemetry_sdk::export::trace::SpanExporter for SpanExporter {
124+
impl opentelemetry_sdk::trace::SpanExporter for SpanExporter {
125125
fn export(&mut self, batch: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
126126
self.0.export(batch)
127127
}

opentelemetry-proto/src/transform/trace.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pub mod tonic {
88
};
99
use opentelemetry::trace;
1010
use opentelemetry::trace::{Link, SpanId, SpanKind};
11-
use opentelemetry_sdk::export::trace::SpanData;
11+
use opentelemetry_sdk::trace::SpanData;
1212
use std::collections::HashMap;
1313

1414
impl From<SpanKind> for span::SpanKind {
@@ -45,8 +45,8 @@ pub mod tonic {
4545
}
4646
}
4747
}
48-
impl From<opentelemetry_sdk::export::trace::SpanData> for Span {
49-
fn from(source_span: opentelemetry_sdk::export::trace::SpanData) -> Self {
48+
impl From<opentelemetry_sdk::trace::SpanData> for Span {
49+
fn from(source_span: opentelemetry_sdk::trace::SpanData) -> Self {
5050
let span_kind: span::SpanKind = source_span.span_kind.into();
5151
Span {
5252
trace_id: source_span.span_context.trace_id().to_bytes().to_vec(),
@@ -198,8 +198,8 @@ mod tests {
198198
};
199199
use opentelemetry::InstrumentationScope;
200200
use opentelemetry::KeyValue;
201-
use opentelemetry_sdk::export::trace::SpanData;
202201
use opentelemetry_sdk::resource::Resource;
202+
use opentelemetry_sdk::trace::SpanData;
203203
use opentelemetry_sdk::trace::{SpanEvents, SpanLinks};
204204
use std::borrow::Cow;
205205
use std::time::{Duration, SystemTime};

opentelemetry-proto/src/transform/tracez.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#[cfg(all(feature = "gen-tonic-messages", feature = "zpages"))]
22
mod tonic {
33
use opentelemetry::trace::{Event, Status};
4-
use opentelemetry_sdk::export::trace::SpanData;
4+
use opentelemetry_sdk::trace::SpanData;
55

66
use crate::proto::tonic::{
77
trace::v1::{span::Event as SpanEvent, Status as SpanStatus},

opentelemetry-sdk/CHANGELOG.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,12 +268,26 @@ hardcoded limit of 2000 and no ability to change it. This feature will be
268268
re-introduced in a future date, along with the ability to change the cardinality
269269
limit.
270270

271-
- *Breaking (Affects custom LogExporter, LogProcessor authors only)*: Rename namespaces
271+
272+
- *Breaking* (Affects custom Exporter authors only) Moved `ExportError` trait from `opentelemetry::export::ExportError` to `opentelemetry_sdk::ExportError`
273+
- *Breaking (Affects custom SpanExporter, SpanProcessor authors only)*: Rename namespaces for Span exporter structs/traits
274+
before:
275+
`opentelemetry_sdk::export::spans::{ExportResult, SpanData, SpanExporter};`
276+
now:
277+
`opentelemetry_sdk::spans::{ExportResult, SpanData, SpanExporter};`
278+
279+
- *Breaking (Affects custom LogExporter, LogProcessor authors only)*: Rename namespaces for Log exporter structs/traits.
272280
before:
273281
`opentelemetry_sdk::export::logs::{ExportResult, LogBatch, LogExporter};`
274282
now:
275283
`opentelemetry_sdk::logs::{ExportResult, LogBatch, LogExporter};`
276284

285+
- *Breaking*: Rename namespaces for InMemoryExporters. (The module is still under "testing" feature flag)
286+
before:
287+
`opentelemetry_sdk::testing::logs::{InMemoryLogExporter, InMemoryLogExporterBuilder};`
288+
now:
289+
`opentelemetry_sdk::logs::{InMemoryLogExporter, InMemoryLogExporterBuilder};`
290+
277291
## 0.27.1
278292

279293
Released 2024-Nov-27

0 commit comments

Comments
 (0)