chore: Fix changelogs and few nits (#2929)

Author: cijothomas

.cspell.json

@@ -29,6 +29,7 @@
         "anyvalue",
         "appender",
         "appenders",
+        "autobenches",
         "Bhasin",
         "BLRP",
         "Cijo",

examples/metrics-advanced/Cargo.toml

@@ -13,6 +13,6 @@ bench = false
 
 [dependencies]
 opentelemetry = { path = "../../opentelemetry", features = ["metrics"] }
-opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["spec_unstable_metrics_views", "rt-tokio"] }
+opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["spec_unstable_metrics_views"] }
 opentelemetry-stdout = { workspace = true, features = ["metrics"] }
 tokio = { workspace = true, features = ["full"] }

examples/metrics-basic/Cargo.toml

@@ -13,7 +13,7 @@ bench = false
 
 [dependencies]
 opentelemetry = { path = "../../opentelemetry", features = ["metrics"] }
-opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["metrics", "rt-tokio"] }
+opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["metrics"] }
 opentelemetry-stdout = { workspace = true, features = ["metrics"] }
 tokio = { workspace = true, features = ["full"] }
 

opentelemetry-sdk/CHANGELOG.md

@@ -2,14 +2,16 @@
 
 ## vNext
 
-[#2868](https://github.com/open-telemetry/opentelemetry-rust/pull/2868)
-`SdkLogger`, `SdkTracer` modified to respect telemetry suppression based on
+- **Feature**: Added context based telemetry suppression. [#2868](https://github.com/open-telemetry/opentelemetry-rust/pull/2868)
+  - `SdkLogger`, `SdkTracer` modified to respect telemetry suppression based on
 `Context`. In other words, if the current context has telemetry suppression
-enabled, then logs/spans will be ignored. The flag is typically set by OTel
+enabled, then logs/spans will be ignored.
+  - The flag is typically set by OTel
 components to prevent telemetry from itself being fed back into OTel.
-`BatchLogProcessor`, `BatchSpanProcessor`, and `PeriodicReader` modified to set
+  - `BatchLogProcessor`, `BatchSpanProcessor`, and `PeriodicReader` modified to set
 the suppression flag in their dedicated thread, so that telemetry generated from
-those threads will not be fed back into OTel. Similarly, `SimpleLogProcessor`
+those threads will not be fed back into OTel.
+  - Similarly, `SimpleLogProcessor`
 also modified to suppress telemetry before invoking exporters.
 
 - **Feature**: Implemented and enabled cardinality capping for Metrics by
@@ -25,20 +27,21 @@ also modified to suppress telemetry before invoking exporters.
     [#2878](https://github.com/open-telemetry/opentelemetry-rust/issues/2878)
 - *Breaking* `MetricError`, `MetricResult` no longer public (except when
   `spec_unstable_metrics_views` feature flag is enabled). `OTelSdkResult` should
-  be used instead, wherever applicable.
-- *Breaking* change, affecting custom MetricReader authors:   The
-  `shutdown_with_timeout` method is added to `MetricReader` trait. `collect`
+  be used instead, wherever applicable. [#2906](https://github.com/open-telemetry/opentelemetry-rust/pull/2906)
+- *Breaking* change, affecting custom `MetricReader` authors:
+  - The
+  `shutdown_with_timeout` method is added to `MetricReader` trait.
+  - `collect`
   method on `MetricReader` modified to return `OTelSdkResult`.
   [#2905](https://github.com/open-telemetry/opentelemetry-rust/pull/2905)
-  [#2905](https://github.com/open-telemetry/opentelemetry-rust/pull/2905)
-- *Breaking* change, affecting custom MetricReader authors: `MetricReader`
+  - `MetricReader`
   trait, `ManualReader` struct, `Pipeline` struct, `InstrumentKind` enum moved
-  behind feature flag "experimental_metrics_custom_reader". These were only
-  required for writing custom readers.
-  [2928](https://github.com/open-telemetry/opentelemetry-rust/pull/2928)
+  behind feature flag "experimental_metrics_custom_reader".
+  [#2928](https://github.com/open-telemetry/opentelemetry-rust/pull/2928)
+
 - *Breaking* `Aggregation` enum moved behind feature flag
   "spec_unstable_metrics_views". This was only required when using Views.
-  [2928](https://github.com/open-telemetry/opentelemetry-rust/pull/2928)
+  [#2928](https://github.com/open-telemetry/opentelemetry-rust/pull/2928)
 
 ## 0.29.0
 

opentelemetry-sdk/src/metrics/mod.rs

@@ -87,13 +87,9 @@ pub use instrument::InstrumentKind;
 
 #[cfg(feature = "spec_unstable_metrics_views")]
 pub use instrument::*;
-// #[cfg(not(feature = "spec_unstable_metrics_views"))]
-// pub(crate) use instrument::*;
 
 #[cfg(feature = "spec_unstable_metrics_views")]
 pub use view::*;
-// #[cfg(not(feature = "spec_unstable_metrics_views"))]
-// pub(crate) use view::*;
 
 use std::hash::Hash;