Skip to content

Commit 19b5c90

Browse files
clean allowed external types + update CI
1 parent 2150812 commit 19b5c90

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
run: |
103103
cargo install [email protected]
104104
cd ${{ matrix.example }}
105-
cargo check-external-types --config allowed-external-types.toml
105+
cargo check-external-types --all-features --config allowed-external-types.toml
106106
msrv:
107107
strategy:
108108
matrix:

opentelemetry-otlp/allowed-external-types.toml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,16 @@
33
# This is used with cargo-check-external-types to reduce the surface area of downstream crates from
44
# the public API. Ideally this can have a few exceptions as possible.
55
allowed_external_types = [
6-
"opentelemetry::*",
76
"opentelemetry_http::*",
87
"opentelemetry_sdk::*",
9-
# http is a pre 1.0 crate
10-
"http::uri::InvalidUri",
11-
"http::header::name::InvalidHeaderName",
12-
"http::header::value::InvalidHeaderValue",
13-
# prost is a pre 1.0 crate
14-
"prost::error::EncodeError",
8+
# serde
9+
"serde::de::Deserialize",
10+
"serde::ser::Serialize",
1511
# tonic is a pre 1.0 crate
16-
"tonic::status::Code",
17-
"tonic::status::Status",
1812
"tonic::metadata::map::MetadataMap",
1913
"tonic::transport::channel::tls::ClientTlsConfig",
2014
"tonic::transport::tls::Certificate",
2115
"tonic::transport::tls::Identity",
2216
"tonic::transport::channel::Channel",
23-
"tonic::transport::error::Error",
2417
"tonic::service::interceptor::Interceptor",
2518
]

0 commit comments

Comments
 (0)