Increase test coverage

Author: andborja

opentelemetry-declarative-config/src/lib.rs

@@ -21,7 +21,6 @@ use crate::{
         MetricsPullExporterFactory,
         PeriodicExporterFactory,
         PullExporterFactory,
-        exporters::prometheus_pull_exporter::PrometheusMetricsPullExporterFactory,
     },
     telemetry_config::TelemetryConfig,
 };
@@ -262,4 +261,70 @@ mod tests {
         let providers = TelemetryProviders::new();
         assert!(providers.shutdown().is_ok());
     }
+
+    #[test]
+    fn test_configurator_default() -> Result<(), Box<dyn std::error::Error>> {
+        let config = Configurator::default();
+        let telemetry_config = TelemetryConfig::default();
+        let telemetry_providers = config.configure_telemetry(telemetry_config)?;
+
+        assert!(telemetry_providers.meter_provider().is_none());
+        assert!(telemetry_providers.traces_provider().is_none());
+        assert!(telemetry_providers.logs_provider().is_none());
+
+        assert!(telemetry_providers.shutdown().is_ok());
+        Ok(())
+    }
+
+    #[test]
+    fn test_configurator_from_yaml() -> Result<(), Box<dyn std::error::Error>> {
+        let config = Configurator::new();
+        let yaml_str = r#"
+        resource:
+          service.name: test-service
+        metrics:
+          readers:
+            - periodic:
+              exporter:
+                name: stdout
+        logs:
+          processors:
+            - batch:
+              exporter:
+                name: otlp
+        "#;
+        let telemetry_providers = config.configure_telemetry_from_yaml(yaml_str.into())?;
+
+        assert!(telemetry_providers.meter_provider().is_some());
+        assert!(telemetry_providers.logs_provider().is_some());
+        assert!(telemetry_providers.traces_provider().is_none());
+
+        assert!(telemetry_providers.shutdown().is_ok());
+        Ok(())
+    }
+
+    #[test]
+    fn test_telemetry_providers_default() {
+        let providers = TelemetryProviders::default();
+        assert!(providers.meter_provider().is_none());
+        assert!(providers.traces_provider().is_none());
+        assert!(providers.logs_provider().is_none());
+    }
+
+    #[test]
+    fn test_telemetry_providers_getters() {
+        let meter_provider = SdkMeterProvider::builder().build();
+        let logs_provider = SdkLoggerProvider::builder().build();
+        let traces_provider = SdkTracerProvider::builder().build();
+
+        let providers = TelemetryProviders::new()
+            .with_logs_provider(logs_provider)
+            .with_meter_provider(meter_provider)
+            .with_traces_provider(traces_provider);
+
+        assert!(providers.meter_provider().is_some());
+        assert!(providers.traces_provider().is_some());
+        assert!(providers.logs_provider().is_some());
+        providers.shutdown().unwrap();
+    }
 }

opentelemetry-declarative-config/src/metrics/exporters.rs

@@ -67,4 +67,12 @@ mod tests {
             panic!("Expected error for unknown temporality");
         }
     }
+
+    #[test]
+    fn test_deserialize_no_temporality() {
+        let yaml_cumulative = r#"
+        "#;
+        let temporality_holder: MockTemporalityHolder = serde_yaml::from_str(yaml_cumulative).unwrap();
+        assert_eq!(temporality_holder.temporality, None);
+    }
 }