Skip to content

Commit 1bf3d45

Browse files
committed
Address feedback
1 parent 9b661f4 commit 1bf3d45

File tree

1 file changed

+2
-13
lines changed
  • opentelemetry-sdk/src/export/logs

1 file changed

+2
-13
lines changed

opentelemetry-sdk/src/export/logs/mod.rs

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -144,21 +144,10 @@ pub trait LogExporter: Send + Sync + Debug {
144144
true
145145
}
146146

147-
/// This is a hint to ensure that the export of any Logs the exporter
148-
/// has received prior to the call to this function SHOULD be completed
149-
/// as soon as possible, preferably before returning from this method.
150147
///
151-
/// This function SHOULD provide a way to let the caller know
152-
/// whether it succeeded, failed or timed out.
148+
/// This method SHOULD block the current thread until all pending log records are exported.
149+
/// If the export was not successful, an error is returned.
153150
///
154-
/// This function SHOULD only be called in cases where it is absolutely necessary,
155-
/// such as when using some FaaS providers that may suspend the process after
156-
/// an invocation, but before the exporter exports the completed logs.
157-
///
158-
/// This function SHOULD complete or abort within some timeout. This function can be
159-
/// implemented as a blocking API or an asynchronous API which notifies the caller via
160-
/// a callback or an event. OpenTelemetry client authors can decide if they want to
161-
/// make the flush timeout configurable.
162151
fn force_flush(&mut self) -> ExportResult {
163152
Ok(())
164153
}

0 commit comments

Comments
 (0)