Skip to content

Commit 1ef8a02

Browse files
committed
Fix post rebase
1 parent 2664e0f commit 1ef8a02

File tree

10 files changed

+45
-45
lines changed

10 files changed

+45
-45
lines changed

examples/metrics-basic/src/main.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,19 +152,19 @@ async fn main() -> Result<(), Box<dyn Error>> {
152152
// Ok(_) => println!("MeterProvider shutdown successfully"),
153153
// Err(e) => {
154154
// match e {
155-
// opentelemetry_sdk::error::ShutdownError::InternalFailure(message) => {
155+
// opentelemetry_sdk::error::OTelSdkError::InternalFailure(message) => {
156156
// // This indicates some internal failure during shutdown. The
157157
// // error message is intended for logging purposes only and
158158
// // should not be used to make programmatic decisions.
159159
// println!("MeterProvider shutdown failed: {}", message)
160160
// }
161-
// opentelemetry_sdk::error::ShutdownError::AlreadyShutdown => {
161+
// opentelemetry_sdk::error::OTelSdkError::AlreadyShutdown => {
162162
// // This indicates some user code tried to shutdown
163163
// // elsewhere. user need to review their code to ensure
164164
// // shutdown is called only once.
165165
// println!("MeterProvider already shutdown")
166166
// }
167-
// opentelemetry_sdk::error::ShutdownError::Timeout(e) => {
167+
// opentelemetry_sdk::error::OTelSdkError::Timeout(e) => {
168168
// // This indicates the shutdown timed out, and a good hint to
169169
// // user to increase the timeout. (Shutdown method does not
170170
// // allow custom timeout today, but that is temporary)

opentelemetry-otlp/src/exporter/http/logs.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::sync::Arc;
22

33
use http::{header::CONTENT_TYPE, Method};
44
use opentelemetry::otel_debug;
5-
use opentelemetry_sdk::error::{ShutdownError, ShutdownResult};
5+
use opentelemetry_sdk::error::{OTelSdkError, OTelSdkResult};
66
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
77
use opentelemetry_sdk::logs::{LogError, LogResult};
88

@@ -54,10 +54,10 @@ impl LogExporter for OtlpHttpClient {
5454
}
5555
}
5656

57-
fn shutdown(&mut self) -> ShutdownResult {
57+
fn shutdown(&mut self) -> OTelSdkResult {
5858
self.client
5959
.lock()
60-
.map_err(|e| ShutdownError::InternalFailure(format!("Failed to acquire lock: {}", e)))?
60+
.map_err(|e| OTelSdkError::InternalFailure(format!("Failed to acquire lock: {}", e)))?
6161
.take();
6262
Ok(())
6363
}

opentelemetry-otlp/src/exporter/tonic/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use opentelemetry::otel_debug;
33
use opentelemetry_proto::tonic::collector::logs::v1::{
44
logs_service_client::LogsServiceClient, ExportLogsServiceRequest,
55
};
6-
use opentelemetry_sdk::error::ShutdownError;
6+
use opentelemetry_sdk::error::OTelSdkResult;
77
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
88
use opentelemetry_sdk::logs::{LogError, LogResult};
99
use tonic::{codegen::CompressionEncoding, service::Interceptor, transport::Channel, Request};
@@ -93,7 +93,7 @@ impl LogExporter for TonicLogsClient {
9393
}
9494
}
9595

96-
fn shutdown(&mut self) -> Result<(), ShutdownError> {
96+
fn shutdown(&mut self) -> OTelSdkResult {
9797
let _ = self.inner.take();
9898
Ok(())
9999
}

opentelemetry-sdk/src/logs/export.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! Log exporters
2-
use crate::error::ShutdownResult;
2+
use crate::error::OTelSdkResult;
33
use crate::logs::LogRecord;
44
use crate::logs::{LogError, LogResult};
55
use crate::Resource;
@@ -137,7 +137,7 @@ pub trait LogExporter: Send + Sync + Debug {
137137
) -> impl std::future::Future<Output = LogResult<()>> + Send;
138138

139139
/// Shuts down the exporter.
140-
fn shutdown(&mut self) -> ShutdownResult {
140+
fn shutdown(&mut self) -> OTelSdkResult {
141141
Ok(())
142142
}
143143
#[cfg(feature = "spec_unstable_logs_enabled")]

opentelemetry-sdk/src/logs/in_memory_exporter.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use crate::error::ShutdownResult;
1+
use crate::error::OTelSdkResult;
22
use crate::logs::LogRecord;
33
use crate::logs::{LogBatch, LogError, LogExporter, LogResult};
44
use crate::Resource;
@@ -199,7 +199,7 @@ impl LogExporter for InMemoryLogExporter {
199199
}
200200
}
201201

202-
fn shutdown(&mut self) -> ShutdownResult {
202+
fn shutdown(&mut self) -> OTelSdkResult {
203203
if self.should_reset_on_shutdown {
204204
self.reset();
205205
}

opentelemetry-sdk/src/logs/log_processor.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
//! ```
3333
3434
use crate::{
35-
error::{ShutdownError, ShutdownResult},
35+
error::{OTelSdkError, OTelSdkResult},
3636
logs::{ExportResult, LogBatch, LogError, LogExporter, LogRecord, LogResult},
3737
Resource,
3838
};
@@ -93,7 +93,7 @@ pub trait LogProcessor: Send + Sync + Debug {
9393
/// Shuts down the processor.
9494
/// After shutdown returns the log processor should stop processing any logs.
9595
/// It's up to the implementation on when to drop the LogProcessor.
96-
fn shutdown(&self) -> ShutdownResult;
96+
fn shutdown(&self) -> OTelSdkResult;
9797

9898
#[cfg(feature = "spec_unstable_logs_enabled")]
9999
/// Check if logging is enabled
@@ -190,12 +190,12 @@ impl<T: LogExporter> LogProcessor for SimpleLogProcessor<T> {
190190
Ok(())
191191
}
192192

193-
fn shutdown(&self) -> ShutdownResult {
193+
fn shutdown(&self) -> OTelSdkResult {
194194
self.is_shutdown
195195
.store(true, std::sync::atomic::Ordering::Relaxed);
196196
self.exporter
197197
.lock()
198-
.map_err(|e| ShutdownError::InternalFailure(format!("Failed to acquire lock: {}", e)))?
198+
.map_err(|e| OTelSdkError::InternalFailure(format!("Failed to acquire lock: {}", e)))?
199199
.shutdown()?;
200200
Ok(())
201201
}
@@ -411,7 +411,7 @@ impl LogProcessor for BatchLogProcessor {
411411
}
412412
}
413413

414-
fn shutdown(&self) -> ShutdownResult {
414+
fn shutdown(&self) -> OTelSdkResult {
415415
let dropped_logs = self.dropped_logs_count.load(Ordering::Relaxed);
416416
let max_queue_size = self.max_queue_size;
417417
if dropped_logs > 0 {
@@ -442,14 +442,14 @@ impl LogProcessor for BatchLogProcessor {
442442
name: "BatchLogProcessor.Shutdown.Timeout",
443443
message = "BatchLogProcessor shutdown timing out."
444444
);
445-
ShutdownError::Timeout(self.shutdown_timeout)
445+
OTelSdkError::Timeout(self.shutdown_timeout)
446446
}
447447
_ => {
448448
otel_error!(
449449
name: "BatchLogProcessor.Shutdown.Error",
450450
error = format!("{}", err)
451451
);
452-
ShutdownError::InternalFailure(err.to_string())
452+
OTelSdkError::InternalFailure(err.to_string())
453453
}
454454
})?
455455
}
@@ -459,7 +459,7 @@ impl LogProcessor for BatchLogProcessor {
459459
name: "BatchLogProcessor.Shutdown.ControlChannelFull",
460460
message = "Control message to shutdown the worker thread could not be sent as the control channel is full. This can occur if user repeatedily calls force_flush/shutdown without finishing the previous call."
461461
);
462-
Err(ShutdownError::InternalFailure("Shutdown cannot be performed as Control channel is full. This can occur if user repeatedily calls force_flush/shutdown without finishing the previous call.".into()))
462+
Err(OTelSdkError::InternalFailure("Shutdown cannot be performed as Control channel is full. This can occur if user repeatedily calls force_flush/shutdown without finishing the previous call.".into()))
463463
}
464464
Err(mpsc::TrySendError::Disconnected(_)) => {
465465
// Given background thread is the only receiver, and it's
@@ -469,7 +469,7 @@ impl LogProcessor for BatchLogProcessor {
469469
message = "Shutdown is being invoked more than once. This is noop, but indicates a potential issue in the application's lifecycle management."
470470
);
471471

472-
Err(ShutdownError::InternalFailure(
472+
Err(OTelSdkError::InternalFailure(
473473
"BatchLogProcessor is already shutdown".into(),
474474
))
475475
}
@@ -875,7 +875,7 @@ mod tests {
875875
BatchLogProcessor, OTEL_BLRP_EXPORT_TIMEOUT, OTEL_BLRP_MAX_EXPORT_BATCH_SIZE,
876876
OTEL_BLRP_MAX_QUEUE_SIZE, OTEL_BLRP_SCHEDULE_DELAY,
877877
};
878-
use crate::error::ShutdownResult;
878+
use crate::error::OTelSdkResult;
879879
use crate::logs::LogResult;
880880
use crate::logs::{LogBatch, LogExporter, LogRecord};
881881
use crate::{
@@ -912,7 +912,7 @@ mod tests {
912912
async { Ok(()) }
913913
}
914914

915-
fn shutdown(&mut self) -> ShutdownResult {
915+
fn shutdown(&mut self) -> OTelSdkResult {
916916
Ok(())
917917
}
918918

@@ -1236,7 +1236,7 @@ mod tests {
12361236
Ok(())
12371237
}
12381238

1239-
fn shutdown(&self) -> ShutdownResult {
1239+
fn shutdown(&self) -> OTelSdkResult {
12401240
Ok(())
12411241
}
12421242
}
@@ -1266,7 +1266,7 @@ mod tests {
12661266
Ok(())
12671267
}
12681268

1269-
fn shutdown(&self) -> ShutdownResult {
1269+
fn shutdown(&self) -> OTelSdkResult {
12701270
Ok(())
12711271
}
12721272
}

opentelemetry-sdk/src/logs/log_processor_with_async_runtime.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use crate::{
2-
error::{ShutdownError, ShutdownResult},
2+
error::{OTelSdkError, OTelSdkResult},
33
logs::{ExportResult, LogBatch, LogError, LogExporter, LogRecord, LogResult},
44
Resource,
55
};
@@ -87,7 +87,7 @@ impl<R: RuntimeChannel> LogProcessor for BatchLogProcessor<R> {
8787
.and_then(std::convert::identity)
8888
}
8989

90-
fn shutdown(&self) -> ShutdownResult {
90+
fn shutdown(&self) -> OTelSdkResult {
9191
let dropped_logs = self.dropped_logs_count.load(Ordering::Relaxed);
9292
let max_queue_size = self.max_queue_size;
9393
if dropped_logs > 0 {
@@ -101,10 +101,10 @@ impl<R: RuntimeChannel> LogProcessor for BatchLogProcessor<R> {
101101
let (res_sender, res_receiver) = oneshot::channel();
102102
self.message_sender
103103
.try_send(BatchMessage::Shutdown(res_sender))
104-
.map_err(|err| ShutdownError::InternalFailure(err.to_string()))?;
104+
.map_err(|err| OTelSdkError::InternalFailure(err.to_string()))?;
105105

106106
futures_executor::block_on(res_receiver)
107-
.map_err(|err| ShutdownError::InternalFailure(err.to_string()))
107+
.map_err(|err| OTelSdkError::InternalFailure(err.to_string()))
108108
.and_then(std::convert::identity)
109109
}
110110

@@ -287,7 +287,7 @@ where
287287

288288
#[cfg(all(test, feature = "testing", feature = "logs"))]
289289
mod tests {
290-
use crate::error::ShutdownResult;
290+
use crate::error::OTelSdkResult;
291291
use crate::logs::log_processor::{
292292
OTEL_BLRP_EXPORT_TIMEOUT, OTEL_BLRP_MAX_EXPORT_BATCH_SIZE, OTEL_BLRP_MAX_QUEUE_SIZE,
293293
OTEL_BLRP_SCHEDULE_DELAY,
@@ -331,7 +331,7 @@ mod tests {
331331
async { Ok(()) }
332332
}
333333

334-
fn shutdown(&mut self) -> ShutdownResult {
334+
fn shutdown(&mut self) -> OTelSdkResult {
335335
Ok(())
336336
}
337337

@@ -656,7 +656,7 @@ mod tests {
656656
Ok(())
657657
}
658658

659-
fn shutdown(&self) -> ShutdownResult {
659+
fn shutdown(&self) -> OTelSdkResult {
660660
Ok(())
661661
}
662662
}
@@ -686,7 +686,7 @@ mod tests {
686686
Ok(())
687687
}
688688

689-
fn shutdown(&self) -> ShutdownResult {
689+
fn shutdown(&self) -> OTelSdkResult {
690690
Ok(())
691691
}
692692
}

opentelemetry-sdk/src/logs/logger_provider.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use super::{BatchLogProcessor, LogProcessor, LogRecord, SimpleLogProcessor, TraceContext};
2-
use crate::error::ShutdownError;
2+
use crate::error::OTelSdkError;
33
use crate::logs::{LogError, LogExporter, LogResult};
44
use crate::Resource;
55
use opentelemetry::{otel_debug, otel_info, trace::TraceContextExt, Context, InstrumentationScope};
@@ -132,7 +132,7 @@ struct LoggerProviderInner {
132132

133133
impl LoggerProviderInner {
134134
/// Shuts down the `LoggerProviderInner` and returns any errors.
135-
pub(crate) fn shutdown(&self) -> Vec<ShutdownError> {
135+
pub(crate) fn shutdown(&self) -> Vec<OTelSdkError> {
136136
let mut errs = vec![];
137137
for processor in &self.processors {
138138
if let Err(err) = processor.shutdown() {
@@ -142,12 +142,12 @@ impl LoggerProviderInner {
142142
// which is non-actionable by the user
143143
match err {
144144
// specific handling for mutex poisoning
145-
ShutdownError::AlreadyShutdown => {
145+
OTelSdkError::AlreadyShutdown => {
146146
otel_debug!(
147147
name: "LoggerProvider.Drop.AlreadyShutdown",
148148
);
149149
}
150-
ShutdownError::Timeout(t) => {
150+
OTelSdkError::Timeout(t) => {
151151
otel_debug!(
152152
name: "LoggerProvider.Drop.ExportTimedOut",
153153
error = format!("timed out shutting down; t={:?}", t)
@@ -340,7 +340,7 @@ impl opentelemetry::logs::Logger for Logger {
340340
#[cfg(test)]
341341
mod tests {
342342
use crate::{
343-
error::ShutdownResult,
343+
error::OTelSdkResult,
344344
logs::InMemoryLogExporter,
345345
resource::{
346346
SERVICE_NAME, TELEMETRY_SDK_LANGUAGE, TELEMETRY_SDK_NAME, TELEMETRY_SDK_VERSION,
@@ -395,7 +395,7 @@ mod tests {
395395
Ok(())
396396
}
397397

398-
fn shutdown(&self) -> ShutdownResult {
398+
fn shutdown(&self) -> OTelSdkResult {
399399
self.is_shutdown
400400
.lock()
401401
.map(|mut is_shutdown| *is_shutdown = true)
@@ -808,7 +808,7 @@ mod tests {
808808
Ok(())
809809
}
810810

811-
fn shutdown(&self) -> ShutdownResult {
811+
fn shutdown(&self) -> OTelSdkResult {
812812
*self.shutdown_called.lock().unwrap() = true;
813813
Ok(())
814814
}
@@ -839,7 +839,7 @@ mod tests {
839839
Ok(())
840840
}
841841

842-
fn shutdown(&self) -> ShutdownResult {
842+
fn shutdown(&self) -> OTelSdkResult {
843843
let mut count = self.shutdown_count.lock().unwrap();
844844
*count += 1;
845845
Ok(())

opentelemetry-stdout/src/logs/exporter.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use chrono::{DateTime, Utc};
22
use core::fmt;
3-
use opentelemetry_sdk::error::ShutdownResult;
3+
use opentelemetry_sdk::error::OTelSdkResult;
44
use opentelemetry_sdk::logs::LogBatch;
55
use opentelemetry_sdk::logs::LogResult;
66
use opentelemetry_sdk::Resource;
@@ -64,7 +64,7 @@ impl opentelemetry_sdk::logs::LogExporter for LogExporter {
6464
}
6565
}
6666

67-
fn shutdown(&mut self) -> ShutdownResult {
67+
fn shutdown(&mut self) -> OTelSdkResult {
6868
self.is_shutdown.store(true, atomic::Ordering::SeqCst);
6969
Ok(())
7070
}

stress/src/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use std::ascii::AsciiExt;
1313

1414
use opentelemetry::InstrumentationScope;
1515
use opentelemetry_appender_tracing::layer;
16-
use opentelemetry_sdk::error::ShutdownResult;
16+
use opentelemetry_sdk::error::OTelSdkResult;
1717
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
1818
use opentelemetry_sdk::logs::{LogProcessor, LogRecord, LogResult, LoggerProvider};
1919

@@ -49,7 +49,7 @@ impl LogProcessor for MockLogProcessor {
4949
Ok(())
5050
}
5151

52-
fn shutdown(&self) -> ShutdownResult {
52+
fn shutdown(&self) -> OTelSdkResult {
5353
Ok(())
5454
}
5555
}

0 commit comments

Comments
 (0)