Skip to content

Commit 1f979b5

Browse files
committed
re-export tracing for internal-logs
1 parent f3e93a0 commit 1f979b5

File tree

7 files changed

+17
-36
lines changed

7 files changed

+17
-36
lines changed

opentelemetry-http/Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ default = ["internal-logs"]
1414
hyper = ["dep:http-body-util", "dep:hyper", "dep:hyper-util", "dep:tokio"]
1515
reqwest-rustls = ["reqwest", "reqwest/rustls-tls-native-roots"]
1616
reqwest-rustls-webpki-roots = ["reqwest", "reqwest/rustls-tls-webpki-roots"]
17-
internal-logs = ["tracing", "opentelemetry/internal-logs"]
17+
internal-logs = ["opentelemetry/internal-logs"]
1818

1919
[dependencies]
2020
async-trait = { workspace = true }
@@ -26,12 +26,6 @@ hyper-util = { workspace = true, features = ["client-legacy", "http1", "http2"],
2626
opentelemetry = { version = "0.29", path = "../opentelemetry", features = ["trace"] }
2727
reqwest = { workspace = true, features = ["blocking"], optional = true }
2828
tokio = { workspace = true, features = ["time"], optional = true }
29-
tracing = {workspace = true, optional = true}
30-
31-
[package.metadata.cargo-machete]
32-
ignored = [
33-
"tracing" # needed for `internal-logs`
34-
]
3529

3630
[lints]
3731
workspace = true

opentelemetry-jaeger-propagator/Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,13 @@ rustdoc-args = ["--cfg", "docsrs"]
2323
opentelemetry = { version = "0.29", default-features = false, features = [
2424
"trace",
2525
], path = "../opentelemetry" }
26-
tracing = {workspace = true, optional = true} # optional for opentelemetry internal logging
2726

2827
[dev-dependencies]
2928
opentelemetry = { features = ["testing"], path = "../opentelemetry" }
3029

3130
[features]
3231
default = ["internal-logs"]
33-
internal-logs = ["tracing"]
34-
35-
[package.metadata.cargo-machete]
36-
ignored = [
37-
"tracing" # needed for `internal-logs`
38-
]
32+
internal-logs = []
3933

4034
[lints]
4135
workspace = true

opentelemetry-proto/Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ zpages = ["trace"]
4444
testing = ["opentelemetry/testing"]
4545

4646
# add ons
47-
internal-logs = ["tracing"]
47+
internal-logs = []
4848
with-schemars = ["schemars"]
4949
with-serde = ["serde", "hex", "base64"]
5050

@@ -56,7 +56,6 @@ opentelemetry_sdk = { version = "0.29", default-features = false, path = "../ope
5656
schemars = { workspace = true, optional = true }
5757
serde = { workspace = true, optional = true, features = ["serde_derive"] }
5858
hex = { workspace = true, optional = true }
59-
tracing = {workspace = true, optional = true} # optional for opentelemetry internal logging
6059
base64 = { workspace = true, optional = true }
6160

6261
[dev-dependencies]
@@ -66,10 +65,5 @@ prost-build = { workspace = true }
6665
tempfile = { workspace = true }
6766
serde_json = { workspace = true }
6867

69-
[package.metadata.cargo-machete]
70-
ignored = [
71-
"tracing" # needed for `internal-logs`
72-
]
73-
7468
[lints]
7569
workspace = true

opentelemetry-sdk/Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ url = { workspace = true, optional = true }
2525
tokio = { workspace = true, features = ["rt", "time"], optional = true }
2626
tokio-stream = { workspace = true, optional = true }
2727
http = { workspace = true, optional = true }
28-
tracing = {workspace = true, optional = true}
2928

3029
[package.metadata.docs.rs]
3130
all-features = true
@@ -50,19 +49,14 @@ testing = ["opentelemetry/testing", "trace", "metrics", "logs", "rt-tokio", "rt-
5049
experimental_async_runtime = []
5150
rt-tokio = ["tokio", "tokio-stream", "experimental_async_runtime"]
5251
rt-tokio-current-thread = ["tokio", "tokio-stream", "experimental_async_runtime"]
53-
internal-logs = ["tracing"]
52+
internal-logs = []
5453
experimental_metrics_periodicreader_with_async_runtime = ["metrics"]
5554
spec_unstable_metrics_views = ["metrics"]
5655
experimental_logs_batch_log_processor_with_async_runtime = ["logs"]
5756
experimental_logs_concurrent_log_processor = ["logs"]
5857
experimental_trace_batch_span_processor_with_async_runtime = ["trace"]
5958
experimental_metrics_disable_name_validation = ["metrics"]
6059

61-
[package.metadata.cargo-machete]
62-
ignored = [
63-
"tracing" # needed for `internal-logs`
64-
]
65-
6660
[[bench]]
6761
name = "context"
6862
harness = false

opentelemetry/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## vNext
44

5+
- re-export `tracing` for `internal-logs` feature to remove the need of adding `tracing` as a dependency
6+
57
## 0.29.0
68

79
Released 2025-Mar-21

opentelemetry/src/global/internal_logging.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ macro_rules! otel_info {
2626
(name: $name:expr $(,)?) => {
2727
#[cfg(feature = "internal-logs")]
2828
{
29-
tracing::info!( name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
29+
$crate::info!( name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
3030
}
3131

3232
#[cfg(test)]
@@ -42,7 +42,7 @@ macro_rules! otel_info {
4242
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
4343
#[cfg(feature = "internal-logs")]
4444
{
45-
tracing::info!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+, "");
45+
$crate::info!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+, "");
4646
}
4747

4848
#[cfg(test)]
@@ -77,7 +77,7 @@ macro_rules! otel_warn {
7777
(name: $name:expr $(,)?) => {
7878
#[cfg(feature = "internal-logs")]
7979
{
80-
tracing::warn!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
80+
$crate::warn!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
8181
}
8282

8383
#[cfg(test)]
@@ -93,7 +93,7 @@ macro_rules! otel_warn {
9393
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
9494
#[cfg(feature = "internal-logs")]
9595
{
96-
tracing::warn!(name: $name,
96+
$crate::warn!(name: $name,
9797
target: env!("CARGO_PKG_NAME"),
9898
name = $name,
9999
$($key = {
@@ -135,7 +135,7 @@ macro_rules! otel_debug {
135135
(name: $name:expr $(,)?) => {
136136
#[cfg(feature = "internal-logs")]
137137
{
138-
tracing::debug!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
138+
$crate::debug!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
139139
}
140140

141141
#[cfg(test)]
@@ -151,7 +151,7 @@ macro_rules! otel_debug {
151151
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
152152
#[cfg(feature = "internal-logs")]
153153
{
154-
tracing::debug!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+, "");
154+
$crate::debug!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+, "");
155155
}
156156

157157
#[cfg(test)]
@@ -186,7 +186,7 @@ macro_rules! otel_error {
186186
(name: $name:expr $(,)?) => {
187187
#[cfg(feature = "internal-logs")]
188188
{
189-
tracing::error!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
189+
$crate::error!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, "");
190190
}
191191

192192
#[cfg(test)]
@@ -202,7 +202,7 @@ macro_rules! otel_error {
202202
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
203203
#[cfg(feature = "internal-logs")]
204204
{
205-
tracing::error!(name: $name,
205+
$crate::error!(name: $name,
206206
target: env!("CARGO_PKG_NAME"),
207207
name = $name,
208208
$($key = {

opentelemetry/src/lib.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,3 +299,6 @@ pub mod time {
299299
SystemTime::UNIX_EPOCH + std::time::Duration::from_millis(js_sys::Date::now() as u64)
300300
}
301301
}
302+
303+
#[cfg(feature = "internal-logs")]
304+
pub use tracing::{debug, error, info, warn}; // re-export

0 commit comments

Comments
 (0)