Skip to content

Commit 2590604

Browse files
committed
chore: rename error messages for clarity and consistency
Updated several error log names in `opentelemetry-prometheus/src/lib.rs` for better clarity and consistency. This includes renaming `AcquireLockError`, `ReaderError`, and `MetricValidation` to `MetricScrapeFailed` and `MetricValidationFailed`.
1 parent bee56bc commit 2590604

File tree

1 file changed

+4
-4
lines changed
  • opentelemetry-prometheus/src

1 file changed

+4
-4
lines changed

opentelemetry-prometheus/src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ impl prometheus::core::Collector for Collector {
276276
Ok(guard) => guard,
277277
Err(err) => {
278278
otel_error!(
279-
name: "OpenTelemetryPrometheus.AcquireLockError",
279+
name: "MetricScrapeFailed",
280280
message = err.to_string(),
281281
);
282282
return Vec::new();
@@ -289,7 +289,7 @@ impl prometheus::core::Collector for Collector {
289289
};
290290
if let Err(err) = self.reader.collect(&mut metrics) {
291291
otel_error!(
292-
name: "OpenTelemetryPrometheus.ReaderError",
292+
name: "MetricScrapeFailed",
293293
message = err.to_string(),
294294
);
295295
return vec![];
@@ -422,15 +422,15 @@ fn validate_metrics(
422422
if let Some(existing) = mfs.get(name) {
423423
if existing.get_field_type() != metric_type {
424424
otel_warn!(
425-
name: "OpenTelemetryPrometheus.MetricValidation",
425+
name: "MetricValidationFailed",
426426
message = "Instrument type conflict, using existing type definition",
427427
metric_type = format!("Instrument {name}, Existing: {:?}, dropped: {:?}", existing.get_field_type(), metric_type).as_str(),
428428
);
429429
return (true, None);
430430
}
431431
if existing.get_help() != description {
432432
otel_warn!(
433-
name: "OpenTelemetryPrometheus.MetricValidation",
433+
name: "MetricValidationFailed",
434434
message = "Instrument description conflict, using existing",
435435
metric_description = format!("Instrument {name}, Existing: {:?}, dropped: {:?}", existing.get_help().to_string(), description.to_string()).as_str(),
436436
);

0 commit comments

Comments
 (0)