Skip to content

Commit 26f5f51

Browse files
Copilotcijothomas
andcommitted
Remove test and add changelog entry as requested
Co-authored-by: cijothomas <[email protected]>
1 parent 2d6ca9f commit 26f5f51

File tree

2 files changed

+1
-23
lines changed

2 files changed

+1
-23
lines changed

opentelemetry-sdk/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- TODO: Placeholder for Span processor related things
66
- *Fix* SpanProcessor::on_start is no longer called on non recording spans
77
- **Fix**: Restore true parallel exports in the async-native `BatchSpanProcessor` by honoring `OTEL_BSP_MAX_CONCURRENT_EXPORTS` ([#2959](https://github.com/open-telemetry/opentelemetry-rust/pull/3028)). A regression in [#2685](https://github.com/open-telemetry/opentelemetry-rust/pull/2685) inadvertently awaited the `export()` future directly in `opentelemetry-sdk/src/trace/span_processor_with_async_runtime.rs` instead of spawning it on the runtime, forcing all exports to run sequentially.
8+
- **Feature**: Added `Clone` implementation to `SdkLogger` for API consistency with `SdkTracer` ([#3058](https://github.com/open-telemetry/opentelemetry-rust/issues/3058)).
89

910
## 0.30.0
1011

opentelemetry-sdk/src/logs/logger.rs

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -64,26 +64,3 @@ impl opentelemetry::logs::Logger for SdkLogger {
6464
.any(|processor| processor.event_enabled(level, target, name))
6565
}
6666
}
67-
68-
#[cfg(test)]
69-
mod tests {
70-
use super::*;
71-
use crate::logs::SdkLoggerProvider;
72-
use opentelemetry::logs::Logger;
73-
use opentelemetry::InstrumentationScope;
74-
75-
#[test]
76-
fn test_sdk_logger_clone() {
77-
// Test that SdkLogger can be cloned
78-
let provider = SdkLoggerProvider::builder().build();
79-
let scope = InstrumentationScope::builder("test-logger").build();
80-
let logger = SdkLogger::new(scope, provider);
81-
82-
// Clone should work without error
83-
let cloned_logger = logger.clone();
84-
85-
// Both loggers should be usable
86-
let _record1 = logger.create_log_record();
87-
let _record2 = cloned_logger.create_log_record();
88-
}
89-
}

0 commit comments

Comments
 (0)