review comments

Author: lalitb

opentelemetry-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs

@@ -8,6 +8,7 @@ pub(crate) struct LeakyBucket {
     bucket_size: f64,
     last_time: SystemTime,
 }
+use opentelemetry::otel_debug;
 
 impl LeakyBucket {
     pub(crate) fn new(bucket_size: f64, span_per_sec: f64) -> LeakyBucket {
@@ -53,9 +54,9 @@ impl LeakyBucket {
                     }
                 }
                 Err(err) => {
-                    opentelemetry::otel_debug!(
+                    otel_debug!(
                         name: "JaegerRemoteSampler.LeakyBucket.ClockAdjustment",
-                        message = "jaeger remote sampler detected a rewind in system clock",
+                        message = "Jaeger remote sampler detected a rewind in system clock",
                         reason = format!("{:?}", err),
                     );
                     true

opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampler.rs

@@ -206,7 +206,7 @@ impl JaegerRemoteSampler {
                         Err(err_msg) => {
                             otel_warn!(
                                 name: "JaegerRemoteSampler.UpdateStrategy.RequestFailed",
-                                message: "Failed to fetch the sampling strategy from the remote endpoint. The last successfully fetched configuration will be used if available; otherwise, the default sampler will be applied until a successful configuration fetch.",
+                                message= "Failed to fetch the sampling strategy from the remote endpoint. The last successfully fetched configuration will be used if available; otherwise, the default sampler will be applied until a successful configuration fetch.",
                                 reason = format!("{}", err_msg),
                             );
                         }

opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs

@@ -6,7 +6,7 @@ use crate::trace::sampler::sample_based_on_probability;
 use opentelemetry::trace::{
     SamplingDecision, SamplingResult, TraceContextExt, TraceId, TraceState,
 };
-use opentelemetry::{otel_debug, otel_warn, Context};
+use opentelemetry::{otel_warn, Context};
 use std::collections::HashMap;
 use std::fmt::{Debug, Formatter};
 use std::sync::Mutex;
@@ -141,7 +141,7 @@ impl Inner {
             _ => {
                 otel_warn!(
                     name: "Sampler.JaegerRemote.InvalidStrategy",
-                    message: "Invalid sampling strategy received from the remote endpoint. Expected one of: OperationSampling, RateLimitingSampling, or ProbabilisticSampling. Continuing to use the previous strategy or default sampler until a successful update.",
+                    message = "Invalid sampling strategy received from the remote endpoint. Expected one of: OperationSampling, RateLimitingSampling, or ProbabilisticSampling. Continuing to use the previous strategy or default sampler until a successful update.",
                 );
                 None
             }