Skip to content

Commit 2e5899b

Browse files
authored
Merge branch 'main' into tracer-provider-drop-shutdown-check
2 parents 14a42cc + ea4b5e4 commit 2e5899b

File tree

8 files changed

+294
-140
lines changed

8 files changed

+294
-140
lines changed

opentelemetry-otlp/tests/integration_test/expected/failed_traces.json

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"traceId": "9b458af7378cba65253d7042d34fc72e",
2222
"spanId": "cd7cf7bf939930b7",
2323
"parentSpanId": "",
24+
"flags": 1,
2425
"name": "Sub operation...",
2526
"kind": 1,
2627
"startTimeUnixNano": "1703985537070566698",
@@ -40,32 +41,12 @@
4041
}
4142
],
4243
"status": {}
43-
}
44-
]
45-
}
46-
]
47-
},
48-
{
49-
"resource": {
50-
"attributes": [
51-
{
52-
"key": "service.name",
53-
"value": {
54-
"stringValue": "basic-otlp-tracing-example"
55-
}
56-
}
57-
]
58-
},
59-
"scopeSpans": [
60-
{
61-
"scope": {
62-
"name": "ex.com/basic"
63-
},
64-
"spans": [
44+
},
6545
{
6646
"traceId": "9b458af7378cba65253d7042d34fc72e",
6747
"spanId": "d58cf2d702a061e0",
6848
"parentSpanId": "cd7cf7bf939930b7",
49+
"flags": 1,
6950
"name": "operation",
7051
"kind": 1,
7152
"startTimeUnixNano": "1703985537070558635",

opentelemetry-otlp/tests/integration_test/expected/traces.json

Lines changed: 3 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"traceId": "9b458af7378cba65253d7042d34fc72e",
2222
"spanId": "cd7cf7bf939930b7",
2323
"parentSpanId": "d58cf2d702a061e0",
24+
"flags": 1,
2425
"name": "Sub operation...",
2526
"kind": 1,
2627
"startTimeUnixNano": "1703985537070566698",
@@ -40,32 +41,12 @@
4041
}
4142
],
4243
"status": {}
43-
}
44-
]
45-
}
46-
]
47-
},
48-
{
49-
"resource": {
50-
"attributes": [
51-
{
52-
"key": "service.name",
53-
"value": {
54-
"stringValue": "basic-otlp-tracing-example"
55-
}
56-
}
57-
]
58-
},
59-
"scopeSpans": [
60-
{
61-
"scope": {
62-
"name": "ex.com/basic"
63-
},
64-
"spans": [
44+
},
6545
{
6646
"traceId": "9b458af7378cba65253d7042d34fc72e",
6747
"spanId": "d58cf2d702a061e0",
6848
"parentSpanId": "",
49+
"flags": 1,
6950
"name": "operation",
7051
"kind": 1,
7152
"startTimeUnixNano": "1703985537070558635",
@@ -88,12 +69,6 @@
8869
"value": {
8970
"intValue": "100"
9071
}
91-
},
92-
{
93-
"key": "number/int",
94-
"value": {
95-
"intValue": 100
96-
}
9772
}
9873
]
9974
}

opentelemetry-prometheus/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
## vNext
44

55
- Bump MSRV to 1.70 [#2179](https://github.com/open-telemetry/opentelemetry-rust/pull/2179)
6+
- Update `opentelemetry` dependency version to 0.26
7+
- Update `opentelemetry_sdk` dependency version to 0.26
8+
- Update `opentelemetry-semantic-conventions` dependency version to 0.26
9+
610

711
## v0.17.0
812

opentelemetry-prometheus/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ rustdoc-args = ["--cfg", "docsrs"]
2121

2222
[dependencies]
2323
once_cell = { workspace = true }
24-
opentelemetry = { version = "0.24", default-features = false, features = ["metrics"] }
25-
opentelemetry_sdk = { version = "0.24", default-features = false, features = ["metrics"] }
24+
opentelemetry = { version = "0.26", default-features = false, features = ["metrics"] }
25+
opentelemetry_sdk = { version = "0.26", default-features = false, features = ["metrics"] }
2626
prometheus = "0.13"
2727
protobuf = "2.14"
2828

2929
[dev-dependencies]
30-
opentelemetry-semantic-conventions = { version = "0.16" }
30+
opentelemetry-semantic-conventions = { version = "0.26" }
3131
http-body-util = { workspace = true }
3232
hyper = { workspace = true, features = ["full"] }
3333
hyper-util = { workspace = true, features = ["full"] }

opentelemetry-prometheus/src/config.rs

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
use core::fmt;
22
use once_cell::sync::OnceCell;
33
use opentelemetry::metrics::{MetricsError, Result};
4-
use opentelemetry_sdk::metrics::{
5-
reader::{AggregationSelector, MetricProducer},
6-
ManualReaderBuilder,
7-
};
4+
use opentelemetry_sdk::metrics::ManualReaderBuilder;
85
use std::sync::{Arc, Mutex};
96

107
use crate::{Collector, PrometheusExporter, ResourceSelector};
@@ -105,16 +102,6 @@ impl ExporterBuilder {
105102
self
106103
}
107104

108-
/// Configure the [AggregationSelector] the exporter will use.
109-
///
110-
/// If no selector is provided, the [DefaultAggregationSelector] is used.
111-
///
112-
/// [DefaultAggregationSelector]: opentelemetry_sdk::metrics::reader::DefaultAggregationSelector
113-
pub fn with_aggregation_selector(mut self, agg: impl AggregationSelector + 'static) -> Self {
114-
self.reader = self.reader.with_aggregation_selector(agg);
115-
self
116-
}
117-
118105
/// Configures whether to export resource as attributes with every metric.
119106
///
120107
/// Note that this is orthogonal to the `target_info` metric, which can be disabled using `without_target_info`.
@@ -128,15 +115,6 @@ impl ExporterBuilder {
128115
self
129116
}
130117

131-
/// Registers an external [MetricProducer] with this reader.
132-
///
133-
/// The producer is used as a source of aggregated metric data which is
134-
/// incorporated into metrics collected from the SDK.
135-
pub fn with_producer(mut self, producer: impl MetricProducer + 'static) -> Self {
136-
self.reader = self.reader.with_producer(producer);
137-
self
138-
}
139-
140118
/// Creates a new [PrometheusExporter] from this configuration.
141119
pub fn build(self) -> Result<PrometheusExporter> {
142120
let reader = Arc::new(self.reader.build());

opentelemetry-prometheus/src/lib.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ use opentelemetry::{
105105
use opentelemetry_sdk::{
106106
metrics::{
107107
data::{self, ResourceMetrics, Temporality},
108-
reader::{AggregationSelector, MetricReader, TemporalitySelector},
109-
Aggregation, InstrumentKind, ManualReader, Pipeline,
108+
reader::{MetricReader, TemporalitySelector},
109+
InstrumentKind, ManualReader, Pipeline,
110110
},
111111
Resource, Scope,
112112
};
@@ -160,12 +160,6 @@ impl TemporalitySelector for PrometheusExporter {
160160
}
161161
}
162162

163-
impl AggregationSelector for PrometheusExporter {
164-
fn aggregation(&self, kind: InstrumentKind) -> Aggregation {
165-
self.reader.aggregation(kind)
166-
}
167-
}
168-
169163
impl MetricReader for PrometheusExporter {
170164
fn register_pipeline(&self, pipeline: Weak<Pipeline>) {
171165
self.reader.register_pipeline(pipeline)

0 commit comments

Comments
 (0)