Skip to content

Commit 2eae4d0

Browse files
committed
Removing commentted code; Change.md updated
1 parent 13d6ffd commit 2eae4d0

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

opentelemetry-sdk/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## vNext
44

5+
- *Feature*: Introduced a new feature flag, `experimental_metrics_disable_name_validation`, under the `opentelemetry-sdk`, which allows disabling the Instrument Name Validation. This is useful in scenarios where you need to use *special characters*, *Windows Perf Counter Wildcard Path*, or similar cases. For more details, check [#2543](https://github.com/open-telemetry/opentelemetry-rust/pull/2543).
6+
57
- *Breaking(Affects custom metric exporter authors only)* `start_time` and `time` is moved from DataPoints to aggregations (Sum, Gauge, Histogram, ExpoHistogram) see [#2377](https://github.com/open-telemetry/opentelemetry-rust/pull/2377) and [#2411](https://github.com/open-telemetry/opentelemetry-rust/pull/2411), to reduce memory.
68

79
- *Breaking* `start_time` is no longer optional for `Sum` aggregation, see [#2367](https://github.com/open-telemetry/opentelemetry-rust/pull/2367), but is still optional for `Gauge` aggregation see [#2389](https://github.com/open-telemetry/opentelemetry-rust/pull/2389).

opentelemetry-sdk/src/metrics/meter.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -583,14 +583,6 @@ fn validate_bucket_boundaries(boundaries: &[f64]) -> MetricResult<()> {
583583
Ok(())
584584
}
585585

586-
// Regex pattern for Windows Performance Counter names
587-
// #[cfg(feature = "experimental_metrics_disable_name_validation")]
588-
// fn is_valid_windows_perf_counter_name(name: &str) -> bool {
589-
// let pattern = r"^\\[A-Za-z0-9_ ]+\\[A-Za-z0-9_ /%-]+$";
590-
// let re = Regex::new(pattern).unwrap();
591-
// re.is_match(name)
592-
// }
593-
594586
#[cfg(feature = "experimental_metrics_disable_name_validation")]
595587
fn validate_instrument_name(_name: &str) -> MetricResult<()> {
596588
// No name restrictions when name validation is disabled

0 commit comments

Comments
 (0)