Skip to content

Commit 3397dd2

Browse files
committed
feat: use new and default for ResourceBuilder
1 parent 7545b70 commit 3397dd2

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

opentelemetry-sdk/src/resource/builder.rs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,25 @@ use opentelemetry::{KeyValue, Value};
55
use super::{Resource, ResourceDetector, SERVICE_NAME};
66

77
/// Builder to allow easy composition of a Resource
8-
#[derive(Debug, Default)]
8+
#[derive(Debug)]
99
pub struct ResourceBuilder {
1010
resource: Resource,
1111
}
1212

13-
impl ResourceBuilder {
14-
/// Create ResourceBuilder with an empty [Resource].
15-
pub fn new_empty() -> Self {
13+
impl Default for ResourceBuilder {
14+
/// Create ResourceBuilder with [Resource::default()].
15+
fn default() -> Self {
1616
ResourceBuilder {
17-
resource: Resource::empty(),
17+
resource: Resource::default(),
1818
}
1919
}
20+
}
2021

21-
/// Create ResourceBuilder with a default [Resource].
22-
pub fn new_default() -> Self {
22+
impl ResourceBuilder {
23+
/// Create ResourceBuilder with [Resource::empty()].
24+
pub fn new() -> Self {
2325
ResourceBuilder {
24-
resource: Resource::default(),
26+
resource: Resource::empty(),
2527
}
2628
}
2729

opentelemetry-sdk/src/resource/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,14 @@ impl Resource {
7474
///
7575
/// Starts with a [Resource::empty()].
7676
pub fn builder() -> ResourceBuilder {
77-
ResourceBuilder::new_empty()
77+
ResourceBuilder::new()
7878
}
7979

8080
/// Creates a Builder that allows you to configure multiple aspects of the Resource.
8181
///
8282
/// Starts with a [Resource::default()].
8383
pub fn builder_default() -> ResourceBuilder {
84-
ResourceBuilder::new_default()
84+
ResourceBuilder::default()
8585
}
8686

8787
/// Creates an empty resource.

0 commit comments

Comments
 (0)