fix: name of init function and simplify return value

Author: pitoniak32

opentelemetry-zipkin/src/exporter/mod.rs

@@ -16,7 +16,6 @@ use opentelemetry_sdk::{
     Resource,
 };
 use opentelemetry_semantic_conventions as semcov;
-use std::borrow::Cow;
 use std::net::SocketAddr;
 use std::sync::Arc;
 use std::time::Duration;
@@ -89,22 +88,21 @@ impl ZipkinPipelineBuilder {
     ///
     /// Returns error if the endpoint is not valid or if no http client is provided.
     pub fn init_exporter(mut self) -> Result<Exporter, TraceError> {
-        let (_, endpoint) = self.init_config_and_endpoint();
+        let (_, endpoint) = self.init_resource_and_endpoint();
         self.init_exporter_with_endpoint(endpoint)
     }
 
-    fn init_config_and_endpoint(&mut self) -> (Resource, Endpoint) {
+    fn init_resource_and_endpoint(&mut self) -> (Resource, Endpoint) {
         let service_name = self.service_name.take();
         if let Some(service_name) = service_name {
-            let resource = if let Some(mut cfg) = self.trace_config.take() {
-                cfg.resource = Cow::Owned(Resource::new(
+            let resource = if let Some(cfg) = &self.trace_config {
+                Resource::new(
                     cfg.resource
                         .iter()
                         .filter(|(k, _v)| k.as_str() != semcov::resource::SERVICE_NAME)
                         .map(|(k, v)| KeyValue::new(k.clone(), v.clone()))
                         .collect::<Vec<KeyValue>>(),
-                ));
-                cfg.resource.as_ref().clone()
+                )
             } else {
                 Resource::empty()
             };
@@ -139,7 +137,7 @@ impl ZipkinPipelineBuilder {
 
     /// Install the Zipkin trace exporter pipeline with a simple span processor.
     pub fn install_simple(mut self) -> Result<Tracer, TraceError> {
-        let (resource, endpoint) = self.init_config_and_endpoint();
+        let (resource, endpoint) = self.init_resource_and_endpoint();
         let exporter = self.init_exporter_with_endpoint(endpoint)?;
         let provider = TracerProvider::builder()
             .with_simple_exporter(exporter)
@@ -157,7 +155,7 @@ impl ZipkinPipelineBuilder {
     /// Install the Zipkin trace exporter pipeline with a batch span processor using the specified
     /// runtime.
     pub fn install_batch<R: RuntimeChannel>(mut self, runtime: R) -> Result<Tracer, TraceError> {
-        let (resource, endpoint) = self.init_config_and_endpoint();
+        let (resource, endpoint) = self.init_resource_and_endpoint();
         let exporter = self.init_exporter_with_endpoint(endpoint)?;
         let provider = TracerProvider::builder()
             .with_batch_exporter(exporter, runtime)