rename and handle error

Author: cijothomas

opentelemetry-sdk/benches/log_enabled.rs

@@ -12,7 +12,7 @@
 use criterion::{criterion_group, criterion_main, Criterion};
 use opentelemetry::logs::{Logger, LoggerProvider};
 use opentelemetry_sdk::error::OTelSdkResult;
-use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentProcessor;
+use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentLogProcessor;
 use opentelemetry_sdk::logs::{
     LogBatch, LogExporter, LogProcessor, SdkLoggerProvider, SimpleLogProcessor,
 };
@@ -60,7 +60,7 @@ where
 }
 
 fn criterion_benchmark(c: &mut Criterion) {
-    let processor = SimpleConcurrentProcessor::new(NoopExporter);
+    let processor = SimpleConcurrentLogProcessor::new(NoopExporter);
     benchmark_exporter_enabled_false(c, "exporter_disabled_concurrent_processor", processor);
     let simple = SimpleLogProcessor::new(NoopExporter);
     benchmark_exporter_enabled_false(c, "exporter_disabled_simple_processor", simple);

opentelemetry-sdk/src/logs/concurrent_log_processor.rs

@@ -1,4 +1,4 @@
-use opentelemetry::InstrumentationScope;
+use opentelemetry::{otel_info, InstrumentationScope};
 
 use crate::error::OTelSdkResult;
 
@@ -13,21 +13,27 @@ use super::{LogBatch, LogExporter, LogProcessor, SdkLogRecord};
 /// This is intended to be used when exporting to operating system
 /// tracing facilities like Windows ETW, Linux TracePoints etc.
 #[derive(Debug)]
-pub struct SimpleConcurrentProcessor<T: LogExporter> {
+pub struct SimpleConcurrentLogProcessor<T: LogExporter> {
     exporter: T,
 }
 
-impl<T: LogExporter> SimpleConcurrentProcessor<T> {
+impl<T: LogExporter> SimpleConcurrentLogProcessor<T> {
     /// Creates a new `ConcurrentExportProcessor` with the given exporter.
     pub fn new(exporter: T) -> Self {
         Self { exporter }
     }
 }
 
-impl<T: LogExporter> LogProcessor for SimpleConcurrentProcessor<T> {
+impl<T: LogExporter> LogProcessor for SimpleConcurrentLogProcessor<T> {
     fn emit(&self, record: &mut SdkLogRecord, instrumentation: &InstrumentationScope) {
         let log_tuple = &[(record as &SdkLogRecord, instrumentation)];
-        let _ = futures_executor::block_on(self.exporter.export(LogBatch::new(log_tuple)));
+        let result = futures_executor::block_on(self.exporter.export(LogBatch::new(log_tuple)));
+        if let Err(err) = result {
+            otel_info!(
+                name: "SimpleConcurrentLogProcessor.Emit.ExportError",
+                error = format!("{}",err)
+            );
+        }
     }
 
     fn force_flush(&self) -> OTelSdkResult {

stress/src/logs.rs

@@ -19,7 +19,7 @@
 */
 use opentelemetry_appender_tracing::layer;
 use opentelemetry_sdk::error::OTelSdkResult;
-use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentProcessor;
+use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentLogProcessor;
 use opentelemetry_sdk::logs::SdkLoggerProvider;
 use opentelemetry_sdk::logs::{LogBatch, LogExporter};
 
@@ -65,7 +65,9 @@ fn main() {
 
     // LoggerProvider with a no-op processor.
     let provider: SdkLoggerProvider = SdkLoggerProvider::builder()
-        .with_log_processor(SimpleConcurrentProcessor::new(NoopExporter::new(enabled)))
+        .with_log_processor(SimpleConcurrentLogProcessor::new(NoopExporter::new(
+            enabled,
+        )))
         .build();
 
     // Use the OpenTelemetryTracingBridge to test the throughput of the appender-tracing.