Skip to content

Commit 4149f0d

Browse files
committed
Remove Counter/Add benchmark for delta temporality
1 parent ebf1bb6 commit 4149f0d

File tree

1 file changed

+1
-51
lines changed

1 file changed

+1
-51
lines changed

opentelemetry-sdk/benches/metric.rs

Lines changed: 1 addition & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -132,19 +132,14 @@ fn bench_counter(view: Option<Box<dyn View>>, temporality: &str) -> (SharedReade
132132

133133
fn counters(c: &mut Criterion) {
134134
let (_, cntr) = bench_counter(None, "cumulative");
135-
let (_, cntr2) = bench_counter(None, "delta");
135+
// let (_, cntr2) = bench_counter(None, "delta");
136136
let (_, cntr3) = bench_counter(None, "cumulative");
137137

138138
let mut group = c.benchmark_group("Counter");
139139
group.bench_function("AddNoAttrs", |b| b.iter(|| cntr.add(1, &[])));
140-
group.bench_function("AddNoAttrsDelta", |b| b.iter(|| cntr2.add(1, &[])));
141-
142140
group.bench_function("AddOneAttr", |b| {
143141
b.iter(|| cntr.add(1, &[KeyValue::new("K", "V")]))
144142
});
145-
group.bench_function("AddOneAttrDelta", |b| {
146-
b.iter(|| cntr2.add(1, &[KeyValue::new("K1", "V1")]))
147-
});
148143
group.bench_function("AddThreeAttr", |b| {
149144
b.iter(|| {
150145
cntr.add(
@@ -157,18 +152,6 @@ fn counters(c: &mut Criterion) {
157152
)
158153
})
159154
});
160-
group.bench_function("AddThreeAttrDelta", |b| {
161-
b.iter(|| {
162-
cntr2.add(
163-
1,
164-
&[
165-
KeyValue::new("K2", "V2"),
166-
KeyValue::new("K3", "V3"),
167-
KeyValue::new("K4", "V4"),
168-
],
169-
)
170-
})
171-
});
172155
group.bench_function("AddFiveAttr", |b| {
173156
b.iter(|| {
174157
cntr.add(
@@ -183,20 +166,6 @@ fn counters(c: &mut Criterion) {
183166
)
184167
})
185168
});
186-
group.bench_function("AddFiveAttrDelta", |b| {
187-
b.iter(|| {
188-
cntr2.add(
189-
1,
190-
&[
191-
KeyValue::new("K5", "V5"),
192-
KeyValue::new("K6", "V6"),
193-
KeyValue::new("K7", "V7"),
194-
KeyValue::new("K8", "V8"),
195-
KeyValue::new("K9", "V9"),
196-
],
197-
)
198-
})
199-
});
200169
group.bench_function("AddTenAttr", |b| {
201170
b.iter(|| {
202171
cntr.add(
@@ -216,25 +185,6 @@ fn counters(c: &mut Criterion) {
216185
)
217186
})
218187
});
219-
group.bench_function("AddTenAttrDelta", |b| {
220-
b.iter(|| {
221-
cntr2.add(
222-
1,
223-
&[
224-
KeyValue::new("K10", "V10"),
225-
KeyValue::new("K11", "V11"),
226-
KeyValue::new("K12", "V12"),
227-
KeyValue::new("K13", "V13"),
228-
KeyValue::new("K14", "V14"),
229-
KeyValue::new("K15", "V15"),
230-
KeyValue::new("K16", "V16"),
231-
KeyValue::new("K17", "V17"),
232-
KeyValue::new("K18", "V18"),
233-
KeyValue::new("K19", "V19"),
234-
],
235-
)
236-
})
237-
});
238188

239189
const MAX_DATA_POINTS: i64 = 2000;
240190
let mut max_attributes: Vec<KeyValue> = Vec::new();

0 commit comments

Comments
 (0)