Skip to content

Commit 47266ef

Browse files
committed
comment.
1 parent 8a0e56c commit 47266ef

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

opentelemetry-sdk/src/metrics/meter.rs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,11 @@ impl SdkMeter {
7777
let validation_result = validate_instrument_config(builder.name.as_ref(), &builder.unit);
7878
if let Err(err) = validation_result {
7979
otel_error!(
80-
name: "SdkMeter.CreateCounter.InstrumentCreationFailed",
80+
name: "InstrumentCreationFailed",
8181
meter_name = self.scope.name.as_ref(),
8282
instrument_name = builder.name.as_ref(),
83-
error = format!("Measurements from the counter will be ignored. Reason: {}", err)
83+
message = "Measurements from this counter will be ignored.",
84+
reason = format!("{}", err)
8485
);
8586
return Counter::new(Arc::new(NoopSyncInstrument::new()));
8687
}
@@ -98,10 +99,11 @@ impl SdkMeter {
9899
Ok(counter) => counter,
99100
Err(err) => {
100101
otel_error!(
101-
name: "SdkMeter.CreateCounter.InstrumentCreationFailed",
102+
name: "InstrumentCreationFailed",
102103
meter_name = self.scope.name.as_ref(),
103104
instrument_name = builder.name.as_ref(),
104-
error = format!("Measurements from the counter will be ignored. Reason: {}", err)
105+
message = "Measurements from this counter will be ignored.",
106+
reason = format!("{}", err)
105107
);
106108
Counter::new(Arc::new(NoopSyncInstrument::new()))
107109
}
@@ -119,10 +121,11 @@ impl SdkMeter {
119121
let validation_result = validate_instrument_config(builder.name.as_ref(), &builder.unit);
120122
if let Err(err) = validation_result {
121123
otel_error!(
122-
name: "SdkMeter.CreateObservableCounter.InstrumentCreationFailed",
124+
name: "InstrumentCreationFailed",
123125
meter_name = self.scope.name.as_ref(),
124126
instrument_name = builder.name.as_ref(),
125-
error = format!("Measurements from the observable counter will be ignored. Reason: {}", err));
127+
mesage = "Measurements from this observable counter will be ignored.",
128+
reason = format!("{}", err));
126129
return ObservableCounter::new();
127130
}
128131

@@ -136,10 +139,10 @@ impl SdkMeter {
136139
Ok(ms) => {
137140
if ms.is_empty() {
138141
otel_error!(
139-
name: "SdkMeter.CreateObservableCounter.InstrumentCreationFailed",
142+
name: "InstrumentCreationFailed",
140143
meter_name = self.scope.name.as_ref(),
141144
instrument_name = builder.name.as_ref(),
142-
message = "Measurements from the observable counter will be ignored. Check View Configuration."
145+
message = "Measurements from this observable counter will be ignored. Check View Configuration."
143146
);
144147
return ObservableCounter::new();
145148
}
@@ -156,10 +159,11 @@ impl SdkMeter {
156159
}
157160
Err(err) => {
158161
otel_error!(
159-
name: "SdkMeter.CreateObservableCounter.InstrumentCreationFailed",
162+
name: "InstrumentCreationFailed",
160163
meter_name = self.scope.name.as_ref(),
161164
instrument_name = builder.name.as_ref(),
162-
message = format!("Measurements from the observable counter will be ignored. Reason: {}", err));
165+
message = "Measurements from the observable counter will be ignored.",
166+
reason = format!("{}", err));
163167
ObservableCounter::new()
164168
}
165169
}

0 commit comments

Comments
 (0)