Skip to content

Commit 520c435

Browse files
committed
add changelog, remove println
1 parent 048a355 commit 520c435

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

opentelemetry-sdk/CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,25 @@ let processor = BatchSpanProcessor::builder(exporter)
370370
.build();
371371
```
372372

373+
- **Breaking**
374+
- The public API changes in the Tracing:
375+
- Before:
376+
```rust
377+
fn SpanExporter::export(&mut self, batch: Vec<SpanData>) -> BoxFuture<'static, ExportResult>;
378+
fn SpanExporter::shutdown(&mut self);
379+
fn SpanExporter::force_flush(&mut self) -> BoxFuture<'static, ExportResult>
380+
fn TraerProvider::shutdown(&self) -> TraceResult<()>
381+
fn TracerProvider::force_flush(&self) -> Vec<TraceResult<()>>
382+
```
383+
- After:
384+
```rust
385+
fn SpanExporter::export(&mut self, batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult>;
386+
fn SpanExporter::shutdown(&mut self) -> OTelSdkResult;
387+
fn SpanExporter::force_flush(&mut self) -> BoxFuture<'static, OTelSdkResult>
388+
fn TraerProvider::shutdown(&self) -> OTelSdkResult;
389+
fn TracerProvider::force_flush(&self) -> OTelSdkResult;
390+
```
391+
373392
## 0.27.1
374393

375394
Released 2024-Nov-27

opentelemetry-sdk/src/trace/export.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ pub trait SpanExporter: Send + Sync + Debug {
6363
/// implemented as a blocking API or an asynchronous API which notifies the caller via
6464
/// a callback or an event. OpenTelemetry client authors can decide if they want to
6565
/// make the flush timeout configurable.
66-
fn force_flush(&mut self) -> BoxFuture<'static, OTelSdkResult> {
67-
Box::pin(async { Ok(()) })
66+
fn force_flush(&mut self) -> OTelSdkResult {
67+
Ok(())
6868
}
6969

7070
/// Set the resource for the exporter.

opentelemetry-sdk/src/trace/provider.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,6 @@ mod tests {
821821

822822
// Explicitly shut down the tracer provider
823823
let shutdown_result = tracer_provider1.shutdown();
824-
println!("----->>> Shutdown result: {:?}", shutdown_result);
825824
assert!(shutdown_result.is_ok());
826825

827826
// Verify that shutdown was called exactly once

0 commit comments

Comments
 (0)