Skip to content

Commit 54e067e

Browse files
committed
fix build
1 parent fd6eaa5 commit 54e067e

File tree

4 files changed

+42
-19
lines changed

4 files changed

+42
-19
lines changed

opentelemetry-otlp/tests/integration_test/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ opentelemetry-semantic-conventions = { path = "../../../opentelemetry-semantic-c
2121

2222

2323
[features]
24-
hyper-client = ["opentelemetry-otlp/hyper-client", "opentelemetry-otlp/trace", "opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
25-
reqwest-client = ["opentelemetry-otlp/reqwest-client", "opentelemetry-otlp/trace","opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
26-
reqwest-blocking-client = ["opentelemetry-otlp/reqwest-blocking-client", "opentelemetry-otlp/trace","opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
24+
hyper-client = ["opentelemetry-otlp/hyper-client", "opentelemetry-otlp/http-proto", "opentelemetry-otlp/trace", "opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
25+
reqwest-client = ["opentelemetry-otlp/reqwest-client", "opentelemetry-otlp/http-proto", "opentelemetry-otlp/trace","opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
26+
reqwest-blocking-client = ["opentelemetry-otlp/reqwest-blocking-client", "opentelemetry-otlp/http-proto", "opentelemetry-otlp/trace","opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
2727
tonic-client = ["opentelemetry-otlp/grpc-tonic", "opentelemetry-otlp/trace", "opentelemetry-otlp/logs", "opentelemetry-otlp/metrics"]
2828

2929
# Keep tonic as the default client

opentelemetry-otlp/tests/integration_test/tests/logs.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use log::{info, Level};
55
use opentelemetry::logs::LogError;
66
use opentelemetry::KeyValue;
77
use opentelemetry_appender_log::OpenTelemetryLogBridge;
8-
use opentelemetry_otlp::{LogExporter, WithExportConfig};
8+
use opentelemetry_otlp::LogExporter;
99
use opentelemetry_sdk::logs::LoggerProvider;
1010
use opentelemetry_sdk::{logs as sdklogs, runtime, Resource};
1111
use std::error::Error;
@@ -16,12 +16,15 @@ fn init_logs() -> Result<sdklogs::LoggerProvider, LogError> {
1616
let exporter_builder = LogExporter::builder();
1717
#[cfg(feature = "tonic-client")]
1818
let exporter_builder = exporter_builder.with_tonic();
19-
#[cfg(feature = "hyper-client")]
19+
#[cfg(any(
20+
feature = "hyper-client",
21+
feature = "reqwest-client",
22+
feature = "reqwest-blocking-client"
23+
))]
2024
let exporter_builder = exporter_builder.with_http();
2125

22-
let exporter = exporter_builder
23-
.with_endpoint("0.0.0.0:4317")
24-
.build()?;
26+
let exporter = exporter_builder.build()?;
27+
//let exporter = LogExporter::builder().with_tonic().build()?;
2528

2629
Ok(LoggerProvider::builder()
2730
.with_batch_exporter(exporter, runtime::Tokio)

opentelemetry-otlp/tests/integration_test/tests/traces.rs

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ use opentelemetry::{
88
trace::{TraceContextExt, Tracer},
99
Key, KeyValue,
1010
};
11+
use opentelemetry_otlp::SpanExporter;
12+
1113
use opentelemetry_proto::tonic::trace::v1::TracesData;
1214
use opentelemetry_sdk::{runtime, trace as sdktrace, Resource};
1315
use std::error::Error;
@@ -16,9 +18,18 @@ use std::io::Write;
1618
use std::os::unix::fs::MetadataExt;
1719

1820
fn init_tracer_provider() -> Result<sdktrace::TracerProvider, TraceError> {
19-
let exporter = opentelemetry_otlp::SpanExporter::builder()
20-
.with_tonic()
21-
.build()?;
21+
let exporter_builder = SpanExporter::builder();
22+
#[cfg(feature = "tonic-client")]
23+
let exporter_builder = exporter_builder.with_tonic();
24+
#[cfg(any(
25+
feature = "hyper-client",
26+
feature = "reqwest-client",
27+
feature = "reqwest-blocking-client"
28+
))]
29+
let exporter_builder = exporter_builder.with_http();
30+
31+
let exporter = exporter_builder.build()?;
32+
2233
Ok(opentelemetry_sdk::trace::TracerProvider::builder()
2334
.with_batch_exporter(exporter, runtime::Tokio)
2435
.with_config(

scripts/integration_tests.sh

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
1-
# Run tests with the grpc-tonic feature
2-
cd ./opentelemetry-otlp/tests/integration_test/tests && cargo test --no-default-features --features "tonic-client" -- --ignored
1+
set -e
2+
TEST_DIR="./opentelemetry-otlp/tests/integration_test/tests"
33

4-
# Run tests with the reqwest-client feature
5-
#cd ./opentelemetry-otlp/tests/integration_test/tests && cargo test --no-default-features --features "reqwest-client" -- --ignored
4+
if [ -d "$TEST_DIR" ]; then
5+
cd "$TEST_DIR"
6+
# Run tests with the grpc-tonic feature
7+
cargo test --no-default-features --features "tonic-client" -- --ignored
68

7-
# Run tests with the reqwest-blocking-client feature
8-
#cd ./opentelemetry-otlp/tests/integration_test/tests && cargo test --no-default-features --features "reqwest-blocking-client" -- --ignored
9+
# Run tests with the reqwest-client feature
10+
cargo test --no-default-features --features "reqwest-client" -- --ignored
911

10-
# Run tests with the hyper-client feature
11-
#cd ./opentelemetry-otlp/tests/integration_test/tests && cargo test --no-default-features --features "hyper-client" -- --ignored
12+
# TODO - Uncomment the following lines once the reqwest-blocking-client feature is working.
13+
# cargo test --no-default-features --features "reqwest-blocking-client" -- --ignored
14+
15+
# Run tests with the hyper-client feature
16+
cargo test --no-default-features --features "hyper-client" -- --ignored
17+
else
18+
echo "Directory $TEST_DIR does not exist. Skipping tests."
19+
exit 1
20+
fi

0 commit comments

Comments
 (0)