fix: formatting and clippy

Author: paullegranddc

examples/tracing-http-propagator/src/server.rs

@@ -167,7 +167,8 @@ impl SpanProcessor for RouteConcurrencyCounterSpanProcessor {
 }
 
 fn obfuscate_http_auth_url(s: &str) -> Option<String> {
-    let uri = hyper::http::Uri::from_maybe_shared(s.to_owned()).ok()?;
+    #[allow(clippy::unnecessary_to_owned)]
+    let uri = hyper::http::Uri::from_maybe_shared(s.to_string()).ok()?;
     let authority = uri.authority()?;
     let (_, url) = authority.as_str().split_once('@')?;
     let new_auth = format!("REDACTED_USERNAME:REDACTED_PASSWORD@{url}");

opentelemetry-sdk/src/trace/mod.rs

@@ -39,7 +39,7 @@ pub use id_generator::{IdGenerator, RandomIdGenerator};
 pub use links::SpanLinks;
 pub use provider::{SdkTracerProvider, TracerProviderBuilder};
 pub use sampler::{Sampler, ShouldSample};
-pub use span::{Span, ReadableSpan, FinishedSpan};
+pub use span::{FinishedSpan, ReadableSpan, Span};
 pub use span_limit::SpanLimits;
 pub use span_processor::{
     BatchConfig, BatchConfigBuilder, BatchSpanProcessor, BatchSpanProcessorBuilder,

opentelemetry-sdk/src/trace/span.rs

@@ -215,12 +215,12 @@ impl Span {
         if self.tracer.provider().is_shutdown() {
             return;
         }
-        let provider = self.tracer.provider().clone();
 
         #[cfg(feature = "experimental_span_processor_on_ending")]
         {
+            let provider = self.tracer.provider().clone();
             for processor in provider.span_processors() {
-                processor.on_ending( self);
+                processor.on_ending(self);
             }
         }
 
@@ -230,7 +230,7 @@ impl Span {
             span_context,
             ..
         } = self;
-    
+
         // skip if data has already been exported
         let data = match data.take() {
             Some(data) => data,
@@ -245,8 +245,9 @@ impl Span {
             is_consummed: false,
         };
 
-        for (i, processor) in provider.span_processors().iter().enumerate() {
-            if i == provider.span_processors().len() - 1 {
+        let span_processors = tracer.provider().span_processors();
+        for (i, processor) in span_processors.iter().enumerate() {
+            if i == span_processors.len() - 1 {
                 finished_span.is_last_processor = true;
             }
             finished_span.is_consummed = false;

opentelemetry-sdk/src/trace/span_processor_with_async_runtime.rs

@@ -4,7 +4,7 @@ use crate::runtime::{to_interval_stream, RuntimeChannel, TrySend};
 use crate::trace::BatchConfig;
 use crate::trace::Span;
 use crate::trace::SpanProcessor;
-use crate::trace::{SpanData, FinishedSpan, SpanExporter, ReadableSpan};
+use crate::trace::{FinishedSpan, ReadableSpan, SpanData, SpanExporter};
 use futures_channel::oneshot;
 use futures_util::pin_mut;
 use futures_util::{