Skip to content

Commit 6f25e17

Browse files
committed
perf: Perf optimizations for tracing appender
1 parent 6b221e4 commit 6f25e17

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

opentelemetry-appender-tracing/src/layer.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,7 @@ where
189189

190190
let mut log_record = self.logger.create_log_record();
191191

192-
// TODO: Fix heap allocation
193-
log_record.set_target(target.to_string());
192+
log_record.set_target(target);
194193
log_record.set_event_name(name);
195194
log_record.set_severity_number(severity);
196195
log_record.set_severity_text(metadata.level().as_str());

opentelemetry-sdk/src/logs/logger.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,11 @@ impl opentelemetry::logs::Logger for SdkLogger {
3434

3535
//let mut log_record = record;
3636
if record.trace_context.is_none() {
37-
let trace_context = Context::map_current(|cx| {
38-
cx.has_active_span()
39-
.then(|| TraceContext::from(cx.span().span_context()))
37+
Context::map_current(|cx| {
38+
cx.has_active_span().then(|| {
39+
record.trace_context = Some(TraceContext::from(cx.span().span_context()))
40+
})
4041
});
41-
42-
if let Some(ref trace_context) = trace_context {
43-
record.trace_context = Some(trace_context.clone());
44-
}
4542
}
4643
if record.observed_timestamp.is_none() {
4744
record.observed_timestamp = Some(now());

0 commit comments

Comments
 (0)