review comment

Author: lalitb

opentelemetry-sdk/src/trace/config.rs

@@ -161,21 +161,21 @@ impl Default for Config {
                 "parentbased_jaeger_remote" => {
                     otel_warn!(
                         name: "Sampler.ParentBasedJaegerRemote.Unsupported",
-                        message = "ParentBased JaegerRemote sampler is not implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
+                        message = "OTEL_TRACES_SAMPLER is set to 'parentbased_jaeger_remote' which is not implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
                     );
                     Box::new(Sampler::ParentBased(Box::new(Sampler::AlwaysOn)))
                 }
                 "jaeger_remote" => {
                     otel_warn!(
                         name: "Sampler.JaegerRemote.Unsupported",
-                        message = "JaegerRemote sampler is not implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
+                        message = "OTEL_TRACES_SAMPLER is set to 'jaeger_remote' which is implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
                     );
                     Box::new(Sampler::ParentBased(Box::new(Sampler::AlwaysOn)))
                 }
                 "xray" => {
                     otel_warn!(
                         name: "Sampler.XRay.Unsupported",
-                        message = "AWS X-Ray sampler is not implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
+                        message = "OTEL_TRACES_SAMPLER is set to 'xray'. AWS X-Ray sampler is not implemented in this SDK version. Using fallback sampler: ParentBased(AlwaysOn). Configure an alternative sampler using OTEL_TRACES_SAMPLER"
                     );
                     Box::new(Sampler::ParentBased(Box::new(Sampler::AlwaysOn)))
                 }

opentelemetry-sdk/src/trace/span_processor.rs

@@ -134,7 +134,8 @@ impl SpanProcessor for SimpleSpanProcessor {
             .and_then(|mut exporter| futures_executor::block_on(exporter.export(vec![span])));
 
         if let Err(err) = result {
-            otel_error!(
+            // TODO: check error type, and log `error` only if the error is user-actiobable, else log `debug`
+            otel_debug!(
                 name: "SimpleProcessor.OnEnd.Error",
                 reason = format!("{:?}", err)
             );
@@ -249,8 +250,8 @@ impl<R: RuntimeChannel> SpanProcessor for BatchSpanProcessor<R> {
         let result = self.message_sender.try_send(BatchMessage::ExportSpan(span));
 
         if let Err(err) = result {
-            otel_error!(
-                name: "BatchProcessor.OnEnd.Error",
+            otel_debug!(
+                name: "BatchSpanProcessor.OnEnd.SendResultError",
                 reason = format!("{:?}", TraceError::Other(err.into()))
             );
         }
@@ -368,7 +369,7 @@ impl<R: RuntimeChannel> BatchSpanProcessorInternal<R> {
                     let task = async move {
                         if let Err(err) = export_task.await {
                             otel_error!(
-                                name: "BatchSpanProcessor.Export.Error",
+                                name: "BatchSpanProcessor.OnEnd.Error",
                                 reason = format!("{}", err)
                             );
                         }