Skip to content

Commit 769e4f1

Browse files
Copilotlalitb
andcommitted
Fix Link conversion and module import issues in tracez.rs
Co-authored-by: lalitb <[email protected]>
1 parent 0f17877 commit 769e4f1

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

opentelemetry-otlp/src/transform/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ mod tests {
244244
let resource: ResourceAttributesWithSchema = (&resource).into(); // Convert Resource to ResourceAttributesWithSchema
245245

246246
let grouped_logs =
247-
super::group_logs_by_resource_and_scope(log_batch, &resource);
247+
super::tonic::group_logs_by_resource_and_scope(log_batch, &resource);
248248

249249
assert_eq!(grouped_logs.len(), 1);
250250
let resource_logs = &grouped_logs[0];
@@ -264,7 +264,7 @@ mod tests {
264264
let log_batch = LogBatch::new(&logs);
265265
let resource: ResourceAttributesWithSchema = (&resource).into(); // Convert Resource to ResourceAttributesWithSchema
266266
let grouped_logs =
267-
super::group_logs_by_resource_and_scope(log_batch, &resource);
267+
super::tonic::group_logs_by_resource_and_scope(log_batch, &resource);
268268

269269
assert_eq!(grouped_logs.len(), 1);
270270
let resource_logs = &grouped_logs[0];

opentelemetry-otlp/src/transform/trace.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ mod tests {
195195
let resource: ResourceAttributesWithSchema = (&resource).into(); // Convert Resource to ResourceAttributesWithSchema
196196

197197
let grouped_spans =
198-
super::group_spans_by_resource_and_scope(spans, &resource);
198+
super::tonic::group_spans_by_resource_and_scope(spans, &resource);
199199

200200
assert_eq!(grouped_spans.len(), 1);
201201

@@ -244,7 +244,7 @@ mod tests {
244244
let resource: ResourceAttributesWithSchema = (&resource).into(); // Convert Resource to ResourceAttributesWithSchema
245245

246246
let grouped_spans =
247-
super::group_spans_by_resource_and_scope(spans, &resource);
247+
super::tonic::group_spans_by_resource_and_scope(spans, &resource);
248248

249249
assert_eq!(grouped_spans.len(), 1);
250250

opentelemetry-otlp/src/transform/tracez.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ mod tonic {
88
tracez::v1::{ErrorData, LatencyData, RunningData},
99
};
1010
use crate::transform::common::{to_nanos, tonic::Attributes};
11+
use crate::transform::trace::tonic::link_to_proto_link;
1112

1213
pub fn span_data_to_latency_data(span_data: SpanData) -> LatencyData {
1314
LatencyData {
@@ -18,7 +19,7 @@ mod tonic {
1819
endtime: to_nanos(span_data.end_time),
1920
attributes: Attributes::from(span_data.attributes).0,
2021
events: span_data.events.iter().cloned().map(event_to_span_event).collect(),
21-
links: span_data.links.iter().cloned().map(Into::into).collect(),
22+
links: span_data.links.iter().cloned().map(link_to_proto_link).collect(),
2223
}
2324
}
2425

@@ -30,7 +31,7 @@ mod tonic {
3031
starttime: to_nanos(span_data.start_time),
3132
attributes: Attributes::from(span_data.attributes).0,
3233
events: span_data.events.iter().cloned().map(event_to_span_event).collect(),
33-
links: span_data.links.iter().cloned().map(Into::into).collect(),
34+
links: span_data.links.iter().cloned().map(link_to_proto_link).collect(),
3435
status: match span_data.status {
3536
Status::Error { description } => Some(SpanStatus {
3637
message: description.to_string(),
@@ -49,7 +50,7 @@ mod tonic {
4950
starttime: to_nanos(span_data.start_time),
5051
attributes: Attributes::from(span_data.attributes).0,
5152
events: span_data.events.iter().cloned().map(event_to_span_event).collect(),
52-
links: span_data.links.iter().cloned().map(Into::into).collect(),
53+
links: span_data.links.iter().cloned().map(link_to_proto_link).collect(),
5354
}
5455
}
5556

opentelemetry-proto/tests/json_serde.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#[cfg(all(feature = "with-serde", feature = "gen-tonic-messages"))]
1+
#[cfg(all(feature = "with-serde", feature = "gen-tonic"))]
22
mod json_serde {
33
#[cfg(feature = "logs")]
44
use opentelemetry_proto::tonic::collector::logs::v1::ExportLogsServiceRequest;

0 commit comments

Comments
 (0)