Skip to content

Commit 777fdb9

Browse files
markdingrammarkdingram
authored
Missing metrics creator fns (#425)
1 parent a56337c commit 777fdb9

File tree

1 file changed

+111
-70
lines changed

1 file changed

+111
-70
lines changed

‎opentelemetry/src/metrics/meter.rs

Lines changed: 111 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -60,53 +60,31 @@ impl Meter {
6060
self.instrumentation_library
6161
}
6262

63-
/// Creates a new floating point `ValueObserverBuilder` instrument with the
64-
/// given name and callback
65-
pub fn f64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, f64>
63+
/// Creates a new floating point `CounterBuilder` for `f64` values with the given name.
64+
pub fn f64_counter<T>(&self, name: T) -> CounterBuilder<'_, f64>
6665
where
6766
T: Into<String>,
68-
F: Fn(ObserverResult<f64>) + Send + Sync + 'static,
6967
{
70-
ValueObserverBuilder::new(
71-
self,
72-
name.into(),
73-
AsyncRunner::F64(Box::new(callback)),
74-
NumberKind::F64,
75-
)
68+
CounterBuilder::new(self, name.into(), NumberKind::F64)
7669
}
7770

78-
/// Creates a new integral `ValueObserverBuilder` instrument with the given name
79-
/// and callback
80-
pub fn u64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, u64>
71+
/// Creates a new floating point `UpDownCounterBuilder` for an `f64` up down counter with the given name.
72+
pub fn f64_up_down_counter<T>(&self, name: T) -> UpDownCounterBuilder<'_, f64>
8173
where
8274
T: Into<String>,
83-
F: Fn(ObserverResult<u64>) + Send + Sync + 'static,
8475
{
85-
ValueObserverBuilder::new(
86-
self,
87-
name.into(),
88-
AsyncRunner::U64(Box::new(callback)),
89-
NumberKind::U64,
90-
)
76+
UpDownCounterBuilder::new(self, name.into(), NumberKind::F64)
9177
}
9278

93-
/// Creates a new integral `ValueObserverBuilder` instrument with the given name
94-
/// and callback
95-
pub fn i64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, i64>
79+
/// Creates a new floating point `ValueRecorderBuilder` for `f64` values with the given name.
80+
pub fn f64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, f64>
9681
where
9782
T: Into<String>,
98-
F: Fn(ObserverResult<i64>) + Send + Sync + 'static,
9983
{
100-
ValueObserverBuilder::new(
101-
self,
102-
name.into(),
103-
AsyncRunner::I64(Box::new(callback)),
104-
NumberKind::I64,
105-
)
84+
ValueRecorderBuilder::new(self, name.into(), NumberKind::F64)
10685
}
10786

108-
/// Creates a new floating point `SumObserverBuilder` instrument with the given
109-
/// name and callback
87+
/// Creates a new floating point `SumObserverBuilder` for `f64` values with the given name and callback.
11088
pub fn f64_sum_observer<T, F>(&self, name: T, callback: F) -> SumObserverBuilder<'_, f64>
11189
where
11290
T: Into<String>,
@@ -120,42 +98,77 @@ impl Meter {
12098
)
12199
}
122100

123-
/// Creates a new integral `SumObserverBuilder` instrument with the given name
124-
/// and callback
125-
pub fn u64_sum_observer<T, F>(&self, name: T, callback: F) -> SumObserverBuilder<'_, u64>
101+
/// Creates a new floating point `UpDownSumObserverBuilder` for `f64` values with the given name and callback.
102+
pub fn f64_up_down_sum_observer<T, F>(
103+
&self,
104+
name: T,
105+
callback: F,
106+
) -> UpDownSumObserverBuilder<'_, f64>
126107
where
127108
T: Into<String>,
128-
F: Fn(ObserverResult<u64>) + Send + Sync + 'static,
109+
F: Fn(ObserverResult<f64>) + Send + Sync + 'static,
129110
{
130-
SumObserverBuilder::new(
111+
UpDownSumObserverBuilder::new(
131112
self,
132113
name.into(),
133-
AsyncRunner::U64(Box::new(callback)),
134-
NumberKind::U64,
114+
AsyncRunner::F64(Box::new(callback)),
115+
NumberKind::F64,
135116
)
136117
}
137118

138-
/// Creates a new floating point `UpDownSumObserverBuilder` instrument with the
139-
/// given name and callback
140-
pub fn f64_up_down_sum_observer<T, F>(
141-
&self,
142-
name: T,
143-
callback: F,
144-
) -> UpDownSumObserverBuilder<'_, f64>
119+
/// Creates a new floating point `ValueObserverBuilder` for `f64` values with the given name and callback.
120+
pub fn f64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, f64>
145121
where
146122
T: Into<String>,
147123
F: Fn(ObserverResult<f64>) + Send + Sync + 'static,
148124
{
149-
UpDownSumObserverBuilder::new(
125+
ValueObserverBuilder::new(
150126
self,
151127
name.into(),
152128
AsyncRunner::F64(Box::new(callback)),
153129
NumberKind::F64,
154130
)
155131
}
156132

157-
/// Creates a new integral `SumUpDownObserverBuilder` instrument with the given
158-
/// name and callback
133+
/// Creates a new integer `CounterBuilder` for `i64` values with the given name.
134+
pub fn i64_counter<T>(&self, name: T) -> CounterBuilder<'_, i64>
135+
where
136+
T: Into<String>,
137+
{
138+
CounterBuilder::new(self, name.into(), NumberKind::I64)
139+
}
140+
141+
/// Creates a new integer `UpDownCounterBuilder` for an `i64` up down counter with the given name.
142+
pub fn i64_up_down_counter<T>(&self, name: T) -> UpDownCounterBuilder<'_, i64>
143+
where
144+
T: Into<String>,
145+
{
146+
UpDownCounterBuilder::new(self, name.into(), NumberKind::I64)
147+
}
148+
149+
/// Creates a new integer `ValueRecorderBuilder` for `i64` values with the given name.
150+
pub fn i64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, i64>
151+
where
152+
T: Into<String>,
153+
{
154+
ValueRecorderBuilder::new(self, name.into(), NumberKind::I64)
155+
}
156+
157+
/// Creates a new integer `SumObserverBuilder` for `i64` values with the given name and callback.
158+
pub fn i64_sum_observer<T, F>(&self, name: T, callback: F) -> SumObserverBuilder<'_, i64>
159+
where
160+
T: Into<String>,
161+
F: Fn(ObserverResult<i64>) + Send + Sync + 'static,
162+
{
163+
SumObserverBuilder::new(
164+
self,
165+
name.into(),
166+
AsyncRunner::I64(Box::new(callback)),
167+
NumberKind::I64,
168+
)
169+
}
170+
171+
/// Creates a new integer `UpDownSumObserverBuilder` for `i64` values with the given name and callback.
159172
pub fn i64_up_down_sum_observer<T, F>(
160173
&self,
161174
name: T,
@@ -173,60 +186,88 @@ impl Meter {
173186
)
174187
}
175188

176-
/// Creates a new `ValueRecorderBuilder` for `f64` values with the given name.
177-
pub fn f64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, f64>
189+
/// Creates a new integer `ValueObserverBuilder` for `i64` values with the given name and callback.
190+
pub fn i64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, i64>
178191
where
179192
T: Into<String>,
193+
F: Fn(ObserverResult<i64>) + Send + Sync + 'static,
180194
{
181-
ValueRecorderBuilder::new(self, name.into(), NumberKind::F64)
195+
ValueObserverBuilder::new(
196+
self,
197+
name.into(),
198+
AsyncRunner::I64(Box::new(callback)),
199+
NumberKind::I64,
200+
)
182201
}
183202

184-
/// Creates a new `ValueRecorderBuilder` for `i64` values with the given name.
185-
pub fn i64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, i64>
203+
/// Creates a new integer `CounterBuilder` for `u64` values with the given name.
204+
pub fn u64_counter<T>(&self, name: T) -> CounterBuilder<'_, u64>
186205
where
187206
T: Into<String>,
188207
{
189-
ValueRecorderBuilder::new(self, name.into(), NumberKind::I64)
208+
CounterBuilder::new(self, name.into(), NumberKind::U64)
190209
}
191210

192-
/// Creates a new `ValueRecorderBuilder` for `u64` values with the given name.
193-
pub fn u64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, u64>
211+
/// Creates a new integer `UpDownCounterBuilder` for an `u64` up down counter with the given name.
212+
pub fn u64_up_down_counter<T>(&self, name: T) -> UpDownCounterBuilder<'_, u64>
194213
where
195214
T: Into<String>,
196215
{
197-
ValueRecorderBuilder::new(self, name.into(), NumberKind::U64)
216+
UpDownCounterBuilder::new(self, name.into(), NumberKind::U64)
198217
}
199218

200-
/// Creates a new integer `CounterBuilder` for `u64` values with the given name.
201-
pub fn u64_counter<T>(&self, name: T) -> CounterBuilder<'_, u64>
219+
/// Creates a new integer `ValueRecorderBuilder` for `u64` values with the given name.
220+
pub fn u64_value_recorder<T>(&self, name: T) -> ValueRecorderBuilder<'_, u64>
202221
where
203222
T: Into<String>,
204223
{
205-
CounterBuilder::new(self, name.into(), NumberKind::U64)
224+
ValueRecorderBuilder::new(self, name.into(), NumberKind::U64)
206225
}
207226

208-
/// Creates a new floating point `CounterBuilder` for `f64` values with the given name.
209-
pub fn f64_counter<T>(&self, name: T) -> CounterBuilder<'_, f64>
227+
/// Creates a new integer `SumObserverBuilder` for `u64` values with the given name and callback.
228+
pub fn u64_sum_observer<T, F>(&self, name: T, callback: F) -> SumObserverBuilder<'_, u64>
210229
where
211230
T: Into<String>,
231+
F: Fn(ObserverResult<u64>) + Send + Sync + 'static,
212232
{
213-
CounterBuilder::new(self, name.into(), NumberKind::F64)
233+
SumObserverBuilder::new(
234+
self,
235+
name.into(),
236+
AsyncRunner::U64(Box::new(callback)),
237+
NumberKind::U64,
238+
)
214239
}
215240

216-
/// Creates a new integer `UpDownCounterBuilder` for an `i64` up down counter with the given name.
217-
pub fn i64_up_down_counter<T>(&self, name: T) -> UpDownCounterBuilder<'_, i64>
241+
/// Creates a new integer `UpDownSumObserverBuilder` for `u64` values with the given name and callback.
242+
pub fn u64_up_down_sum_observer<T, F>(
243+
&self,
244+
name: T,
245+
callback: F,
246+
) -> UpDownSumObserverBuilder<'_, u64>
218247
where
219248
T: Into<String>,
249+
F: Fn(ObserverResult<u64>) + Send + Sync + 'static,
220250
{
221-
UpDownCounterBuilder::new(self, name.into(), NumberKind::I64)
251+
UpDownSumObserverBuilder::new(
252+
self,
253+
name.into(),
254+
AsyncRunner::U64(Box::new(callback)),
255+
NumberKind::U64,
256+
)
222257
}
223258

224-
/// Creates a new floating point `UpDownCounterBuilder` for an `f64` up down counter with the given name.
225-
pub fn f64_up_down_counter<T>(&self, name: T) -> UpDownCounterBuilder<'_, f64>
259+
/// Creates a new integer `ValueObserverBuilder` for `u64` values with the given name and callback.
260+
pub fn u64_value_observer<T, F>(&self, name: T, callback: F) -> ValueObserverBuilder<'_, u64>
226261
where
227262
T: Into<String>,
263+
F: Fn(ObserverResult<u64>) + Send + Sync + 'static,
228264
{
229-
UpDownCounterBuilder::new(self, name.into(), NumberKind::F64)
265+
ValueObserverBuilder::new(
266+
self,
267+
name.into(),
268+
AsyncRunner::U64(Box::new(callback)),
269+
NumberKind::U64,
270+
)
230271
}
231272

232273
/// Creates a new `BatchObserver` that supports making batches of observations for

0 commit comments

Comments
 (0)