Skip to content

Commit 7a0024e

Browse files
cijothomasutpilla
andauthored
Apply suggestions from code review
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
1 parent 06e796c commit 7a0024e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

opentelemetry-otlp/src/exporter/tonic/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ impl LogExporter for TonicLogsClient {
8686

8787
fn shutdown(&self) -> OTelSdkResult {
8888
// TODO: Implement actual shutdown
89-
// Due to the use to tokio::sync::Mutex to guard
90-
// the inner client, we need to lock the mutex
89+
// Due to the use of tokio::sync::Mutex to guard
90+
// the inner client, we need to await the call to lock the mutex
9191
// and that requires async runtime.
9292
// It is possible to fix this by using
9393
// a dedicated thread just to handle shutdown.

opentelemetry-sdk/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
`scope` name but instead passes the incoming `name` when invoking
6262
`event_enabled` on processors.
6363
- **Breaking** for custom LogExporter authors: `shutdown()` method in
64-
`LogExporter` trait no longer requires a mutable ref to self. If the exporter
64+
`LogExporter` trait no longer requires a mutable ref to `self`. If the exporter
6565
needs to mutate state, it should rely on interior mutability.
6666
[2764](https://github.com/open-telemetry/opentelemetry-rust/pull/2764)
6767

0 commit comments

Comments
 (0)