Skip to content

Commit 85cdc91

Browse files
Copilotcijothomas
andcommitted
Optimize BatchSpanProcessor to use immutable references for export operations
Co-authored-by: cijothomas <[email protected]>
1 parent 94817d7 commit 85cdc91

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

opentelemetry-sdk/src/trace/span_processor.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ impl BatchSpanProcessor {
331331
);
332332
let _ = Self::get_spans_and_export(
333333
&span_receiver,
334-
&mut exporter,
334+
&exporter,
335335
&mut spans,
336336
&mut last_export_time,
337337
&current_batch_size,
@@ -342,7 +342,7 @@ impl BatchSpanProcessor {
342342
otel_debug!(name: "BatchSpanProcessor.ExportingDueToForceFlush");
343343
let result = Self::get_spans_and_export(
344344
&span_receiver,
345-
&mut exporter,
345+
&exporter,
346346
&mut spans,
347347
&mut last_export_time,
348348
&current_batch_size,
@@ -354,7 +354,7 @@ impl BatchSpanProcessor {
354354
otel_debug!(name: "BatchSpanProcessor.ExportingDueToShutdown");
355355
let result = Self::get_spans_and_export(
356356
&span_receiver,
357-
&mut exporter,
357+
&exporter,
358358
&mut spans,
359359
&mut last_export_time,
360360
&current_batch_size,
@@ -382,7 +382,7 @@ impl BatchSpanProcessor {
382382

383383
let _ = Self::get_spans_and_export(
384384
&span_receiver,
385-
&mut exporter,
385+
&exporter,
386386
&mut spans,
387387
&mut last_export_time,
388388
&current_batch_size,
@@ -437,7 +437,7 @@ impl BatchSpanProcessor {
437437
#[inline]
438438
fn get_spans_and_export<E>(
439439
spans_receiver: &Receiver<SpanData>,
440-
exporter: &mut E,
440+
exporter: &E,
441441
spans: &mut Vec<SpanData>,
442442
last_export_time: &mut Instant,
443443
current_batch_size: &AtomicUsize,
@@ -463,7 +463,7 @@ impl BatchSpanProcessor {
463463

464464
#[allow(clippy::vec_box)]
465465
fn export_batch_sync<E>(
466-
exporter: &mut E,
466+
exporter: &E,
467467
batch: &mut Vec<SpanData>,
468468
last_export_time: &mut Instant,
469469
) -> OTelSdkResult

0 commit comments

Comments
 (0)