Skip to content

Commit 8cd416c

Browse files
committed
remove Array(Bytes)
1 parent bdd9c23 commit 8cd416c

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

opentelemetry-proto/src/transform/common.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ pub mod tonic {
149149
Array::I64(vals) => array_into_proto(vals),
150150
Array::F64(vals) => array_into_proto(vals),
151151
Array::String(vals) => array_into_proto(vals),
152-
Array::Bytes(vals) => array_into_proto(vals),
153152
_ => unreachable!("Nonexistent array type"), // Needs to be updated when new array types are added
154153
})),
155154
_ => unreachable!("Nonexistent value type"), // Needs to be updated when new value types are added

opentelemetry/src/common.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,6 @@ pub enum Array {
189189
F64(Vec<f64>),
190190
/// Array of strings
191191
String(Vec<StringValue>),
192-
/// Array of bytes
193-
Bytes(Vec<BytesValue>),
194192
}
195193

196194
impl fmt::Display for Array {
@@ -209,16 +207,6 @@ impl fmt::Display for Array {
209207
}
210208
write!(fmt, "]")
211209
}
212-
Array::Bytes(values) => {
213-
write!(fmt, "[")?;
214-
for (i, b) in values.iter().enumerate() {
215-
if i > 0 {
216-
write!(fmt, ",")?;
217-
}
218-
write!(fmt, "{}", b)?;
219-
}
220-
write!(fmt, "]")
221-
}
222210
}
223211
}
224212
}
@@ -251,7 +239,6 @@ into_array!(
251239
(Vec<i64>, Array::I64),
252240
(Vec<f64>, Array::F64),
253241
(Vec<StringValue>, Array::String),
254-
(Vec<BytesValue>, Array::Bytes),
255242
);
256243

257244
/// The value part of attribute [KeyValue] pairs.

opentelemetry/src/metrics/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ impl Hash for KeyValue {
4444
Array::I64(i) => i.hash(state),
4545
Array::F64(f) => f.iter().for_each(|f| F64Hashable(*f).hash(state)),
4646
Array::String(s) => s.hash(state),
47-
Array::Bytes(b) => b.hash(state),
4847
},
4948
Value::Bool(b) => b.hash(state),
5049
Value::I64(i) => i.hash(state),

0 commit comments

Comments
 (0)