review comment

Author: lalitb

opentelemetry-appender-tracing/benches/logs.rs

@@ -13,7 +13,6 @@
     | ot_layer_enabled            | 196 ns      |
 */
 
-use async_trait::async_trait;
 use criterion::{criterion_group, criterion_main, Criterion};
 use opentelemetry::InstrumentationScope;
 use opentelemetry_appender_tracing::layer as tracing_layer;
@@ -32,7 +31,6 @@ struct NoopExporter {
     enabled: bool,
 }
 
-#[async_trait]
 impl LogExporter for NoopExporter {
     #[allow(clippy::manual_async_fn)]
     fn export<'a>(

opentelemetry-otlp/src/exporter/http/logs.rs

@@ -1,13 +1,11 @@
 use std::sync::Arc;
 
-use async_trait::async_trait;
 use http::{header::CONTENT_TYPE, Method};
 use opentelemetry_sdk::export::logs::{LogBatch, LogExporter};
 use opentelemetry_sdk::logs::{LogError, LogResult};
 
 use super::OtlpHttpClient;
 
-#[async_trait]
 impl LogExporter for OtlpHttpClient {
     #[allow(clippy::manual_async_fn)]
     fn export<'a>(

opentelemetry-otlp/src/exporter/tonic/logs.rs

@@ -1,4 +1,3 @@
-use async_trait::async_trait;
 use core::fmt;
 use opentelemetry::otel_debug;
 use opentelemetry_proto::tonic::collector::logs::v1::{
@@ -56,7 +55,6 @@ impl TonicLogsClient {
     }
 }
 
-#[async_trait]
 impl LogExporter for TonicLogsClient {
     #[allow(clippy::manual_async_fn)]
     fn export<'a>(

opentelemetry-otlp/src/logs.rs

@@ -2,7 +2,6 @@
 //!
 //! Defines a [LogExporter] to send logs via the OpenTelemetry Protocol (OTLP)
 
-use async_trait::async_trait;
 use opentelemetry::otel_debug;
 use std::fmt::Debug;
 
@@ -108,12 +107,11 @@ impl HasHttpConfig for LogExporterBuilder<HttpExporterBuilderSet> {
 /// OTLP exporter that sends log data
 #[derive(Debug)]
 pub struct LogExporter {
-    //client: Box<dyn opentelemetry_sdk::export::logs::LogExporter>,
-    client: LogExporterInner,
+    client: SupportedTransportClient,
 }
 
 #[derive(Debug)]
-enum LogExporterInner {
+enum SupportedTransportClient {
     #[cfg(feature = "grpc-tonic")]
     Tonic(crate::exporter::tonic::logs::TonicLogsClient),
     #[cfg(any(feature = "http-proto", feature = "http-json"))]
@@ -129,19 +127,18 @@ impl LogExporter {
     #[cfg(any(feature = "http-proto", feature = "http-json"))]
     pub(crate) fn from_http(client: crate::exporter::http::OtlpHttpClient) -> Self {
         LogExporter {
-            client: LogExporterInner::Http(client),
+            client: SupportedTransportClient::Http(client),
         }
     }
 
     #[cfg(feature = "grpc-tonic")]
     pub(crate) fn from_tonic(client: crate::exporter::tonic::logs::TonicLogsClient) -> Self {
         LogExporter {
-            client: LogExporterInner::Tonic(client),
+            client: SupportedTransportClient::Tonic(client),
         }
     }
 }
 
-#[async_trait]
 impl opentelemetry_sdk::export::logs::LogExporter for LogExporter {
     #[allow(clippy::manual_async_fn)]
     fn export<'a>(
@@ -151,19 +148,19 @@ impl opentelemetry_sdk::export::logs::LogExporter for LogExporter {
         async move {
             match &self.client {
                 #[cfg(feature = "grpc-tonic")]
-                LogExporterInner::Tonic(client) => client.export(batch).await,
+                SupportedTransportClient::Tonic(client) => client.export(batch).await,
                 #[cfg(any(feature = "http-proto", feature = "http-json"))]
-                LogExporterInner::Http(client) => client.export(batch).await,
+                SupportedTransportClient::Http(client) => client.export(batch).await,
             }
         }
     }
 
     fn set_resource(&mut self, resource: &opentelemetry_sdk::Resource) {
         match &mut self.client {
             #[cfg(feature = "grpc-tonic")]
-            LogExporterInner::Tonic(client) => client.set_resource(resource),
+            SupportedTransportClient::Tonic(client) => client.set_resource(resource),
             #[cfg(any(feature = "http-proto", feature = "http-json"))]
-            LogExporterInner::Http(client) => client.set_resource(resource),
+            SupportedTransportClient::Http(client) => client.set_resource(resource),
         }
     }
 }