Skip to content

Commit 8f0d005

Browse files
committed
add comment for ignore
1 parent f4c73a4 commit 8f0d005

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

opentelemetry-sdk/src/logs/log_processor.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,6 @@ mod tests {
553553
use opentelemetry::InstrumentationLibrary;
554554
use opentelemetry::Key;
555555
use opentelemetry::{logs::LogResult, KeyValue};
556-
// use std::panic;
557556
use std::sync::{Arc, Mutex};
558557
use std::time::Duration;
559558

@@ -1098,8 +1097,6 @@ mod tests {
10981097
#[async_trait::async_trait]
10991098
impl LogExporter for LogExporterThatRequiresTokioSpawn {
11001099
async fn export(&mut self, batch: LogBatch<'_>) -> LogResult<()> {
1101-
println!("Exporting...");
1102-
11031100
// Simulate minimal dependency on tokio by sleeping for a short duration
11041101
sleep(Duration::from_millis(50)).await;
11051102

@@ -1108,8 +1105,6 @@ mod tests {
11081105
for (log_record, instrumentation) in batch.iter() {
11091106
logs_lock.push((log_record.clone(), instrumentation.clone()));
11101107
}
1111-
1112-
println!("Export success...");
11131108
Ok(())
11141109
}
11151110
}
@@ -1193,7 +1188,9 @@ mod tests {
11931188
}
11941189

11951190
#[tokio::test(flavor = "current_thread")]
1196-
#[ignore] // This test hangs as of now.
1191+
#[ignore] // the current thread is blocked with futures::block_on to
1192+
// complete the export, and the exporter further needs tokio runtime to progress
1193+
// on this blocked thread, resulting in deadlock.
11971194
async fn test_simple_processor_async_exporter_with_current_thread_runtime() {
11981195
let exporter = LogExporterThatRequiresTokioSpawn::new();
11991196

0 commit comments

Comments
 (0)