Skip to content

Commit 956b7f0

Browse files
authored
Merge branch 'main' into set_precommit_pwd
2 parents 6e64da4 + 38be4d9 commit 956b7f0

File tree

26 files changed

+152
-142
lines changed

26 files changed

+152
-142
lines changed

opentelemetry-appender-tracing/benches/logs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
use criterion::{criterion_group, criterion_main, Criterion};
1717
use opentelemetry::InstrumentationScope;
1818
use opentelemetry_appender_tracing::layer as tracing_layer;
19-
use opentelemetry_sdk::export::logs::{LogBatch, LogExporter};
2019
use opentelemetry_sdk::logs::LogResult;
20+
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
2121
use opentelemetry_sdk::logs::{LogProcessor, LogRecord, LoggerProvider};
2222
use opentelemetry_sdk::Resource;
2323
use pprof::criterion::{Output, PProfProfiler};

opentelemetry-appender-tracing/src/layer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ mod tests {
213213
use opentelemetry::trace::TracerProvider as _;
214214
use opentelemetry::trace::{TraceContextExt, TraceFlags, Tracer};
215215
use opentelemetry::{logs::AnyValue, Key};
216-
use opentelemetry_sdk::export::logs::{LogBatch, LogExporter};
216+
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
217217
use opentelemetry_sdk::logs::{LogRecord, LogResult, LoggerProvider};
218218
use opentelemetry_sdk::testing::logs::InMemoryLogExporter;
219219
use opentelemetry_sdk::trace::{Sampler, TracerProvider};

opentelemetry-otlp/src/exporter/http/logs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::sync::Arc;
22

33
use http::{header::CONTENT_TYPE, Method};
44
use opentelemetry::otel_debug;
5-
use opentelemetry_sdk::export::logs::{LogBatch, LogExporter};
5+
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
66
use opentelemetry_sdk::logs::{LogError, LogResult};
77

88
use super::OtlpHttpClient;

opentelemetry-otlp/src/exporter/http/mod.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ use opentelemetry_proto::transform::common::tonic::ResourceAttributesWithSchema;
1313
use opentelemetry_proto::transform::logs::tonic::group_logs_by_resource_and_scope;
1414
#[cfg(feature = "trace")]
1515
use opentelemetry_proto::transform::trace::tonic::group_spans_by_resource_and_scope;
16-
#[cfg(feature = "logs")]
17-
use opentelemetry_sdk::export::logs::LogBatch;
1816
#[cfg(feature = "trace")]
1917
use opentelemetry_sdk::export::trace::SpanData;
18+
#[cfg(feature = "logs")]
19+
use opentelemetry_sdk::logs::LogBatch;
2020
use prost::Message;
2121
use std::collections::HashMap;
2222
use std::env;
@@ -27,6 +27,9 @@ use std::time::Duration;
2727
#[cfg(feature = "metrics")]
2828
mod metrics;
2929

30+
#[cfg(feature = "metrics")]
31+
use opentelemetry_sdk::metrics::data::ResourceMetrics;
32+
3033
#[cfg(feature = "logs")]
3134
pub(crate) mod logs;
3235

@@ -336,7 +339,7 @@ impl OtlpHttpClient {
336339
#[cfg(feature = "metrics")]
337340
fn build_metrics_export_body(
338341
&self,
339-
metrics: &mut opentelemetry_sdk::metrics::data::ResourceMetrics,
342+
metrics: &mut ResourceMetrics,
340343
) -> opentelemetry_sdk::metrics::MetricResult<(Vec<u8>, &'static str)> {
341344
use opentelemetry_proto::tonic::collector::metrics::v1::ExportMetricsServiceRequest;
342345

opentelemetry-otlp/src/exporter/tonic/logs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use opentelemetry::otel_debug;
33
use opentelemetry_proto::tonic::collector::logs::v1::{
44
logs_service_client::LogsServiceClient, ExportLogsServiceRequest,
55
};
6-
use opentelemetry_sdk::export::logs::{LogBatch, LogExporter};
6+
use opentelemetry_sdk::logs::{LogBatch, LogExporter};
77
use opentelemetry_sdk::logs::{LogError, LogResult};
88
use tonic::{codegen::CompressionEncoding, service::Interceptor, transport::Channel, Request};
99

opentelemetry-otlp/src/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use std::fmt::Debug;
88

99
use opentelemetry_sdk::logs::LogResult;
1010

11-
use opentelemetry_sdk::export::logs::LogBatch;
11+
use opentelemetry_sdk::logs::LogBatch;
1212

1313
use crate::{HasExportConfig, NoExporterBuilderSet};
1414

@@ -140,7 +140,7 @@ impl LogExporter {
140140
}
141141
}
142142

143-
impl opentelemetry_sdk::export::logs::LogExporter for LogExporter {
143+
impl opentelemetry_sdk::logs::LogExporter for LogExporter {
144144
#[allow(clippy::manual_async_fn)]
145145
fn export(
146146
&self,

opentelemetry-proto/src/transform/logs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ pub mod tonic {
1212
transform::common::{to_nanos, tonic::ResourceAttributesWithSchema},
1313
};
1414
use opentelemetry::logs::{AnyValue as LogsAnyValue, Severity};
15-
use opentelemetry_sdk::export::logs::LogBatch;
15+
use opentelemetry_sdk::logs::LogBatch;
1616
use std::borrow::Cow;
1717
use std::collections::HashMap;
1818

@@ -222,7 +222,7 @@ mod tests {
222222
use crate::transform::common::tonic::ResourceAttributesWithSchema;
223223
use opentelemetry::logs::LogRecord as _;
224224
use opentelemetry::InstrumentationScope;
225-
use opentelemetry_sdk::{export::logs::LogBatch, logs::LogRecord, Resource};
225+
use opentelemetry_sdk::{logs::LogBatch, logs::LogRecord, Resource};
226226
use std::time::SystemTime;
227227

228228
fn create_test_log_data(

opentelemetry-proto/src/transform/metrics.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ pub mod tonic {
1010

1111
use opentelemetry::{otel_debug, Key, Value};
1212
use opentelemetry_sdk::metrics::data::{
13-
self, Exemplar as SdkExemplar, ExponentialHistogram as SdkExponentialHistogram,
14-
Gauge as SdkGauge, Histogram as SdkHistogram, Metric as SdkMetric,
13+
Exemplar as SdkExemplar, ExponentialHistogram as SdkExponentialHistogram,
14+
Gauge as SdkGauge, Histogram as SdkHistogram, Metric as SdkMetric, ResourceMetrics,
1515
ScopeMetrics as SdkScopeMetrics, Sum as SdkSum,
1616
};
1717
use opentelemetry_sdk::metrics::Temporality;
@@ -110,8 +110,8 @@ pub mod tonic {
110110
}
111111
}
112112

113-
impl From<&data::ResourceMetrics> for ExportMetricsServiceRequest {
114-
fn from(rm: &data::ResourceMetrics) -> Self {
113+
impl From<&ResourceMetrics> for ExportMetricsServiceRequest {
114+
fn from(rm: &ResourceMetrics) -> Self {
115115
ExportMetricsServiceRequest {
116116
resource_metrics: vec![TonicResourceMetrics {
117117
resource: Some((&rm.resource).into()),

opentelemetry-sdk/CHANGELOG.md

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
- *Feature*: Add `ResourceBuilder` for an easy way to create new `Resource`s
1818
- *Breaking*: Remove `Resource::{new,empty,from_detectors,new_with_defaults,from_schema_url,merge,default}` from public api. To create Resources you should only use `Resource::builder()` or `Resource::builder_empty()`. See [#2322](https://github.com/open-telemetry/opentelemetry-rust/pull/2322) for a migration guide.
1919
Example Usage:
20+
2021
```rust
2122
// old
2223
Resource::default().with_attributes([
@@ -30,6 +31,7 @@
3031
.with_attribute(KeyValue::new("key", "value"))
3132
.build();
3233
```
34+
3335
- *Breaking* The LogExporter::export() method no longer requires a mutable reference to self.:
3436
Before:
3537
async fn export(&mut self, _batch: LogBatch<'_>) -> LogResult<()>
@@ -61,15 +63,18 @@
6163
1. *Default Implementation, requires no async runtime* (**Recommended**) The
6264
new default implementation does not require a runtime argument. Replace the
6365
builder method accordingly:
64-
- *Before:*
65-
```rust
66-
let reader = opentelemetry_sdk::metrics::PeriodicReader::builder(exporter, runtime::Tokio).build();
67-
```
68-
- *After:*
69-
```rust
70-
let reader = opentelemetry_sdk::metrics::PeriodicReader::builder(exporter).build();
66+
*Before:*
67+
68+
```rust
69+
let reader = opentelemetry_sdk::metrics::PeriodicReader::builder(exporter, runtime::Tokio).build();
7170
```
7271

72+
*After:*
73+
74+
```rust
75+
let reader = opentelemetry_sdk::metrics::PeriodicReader::builder(exporter).build();
76+
```
77+
7378
The new PeriodicReader can be used with OTLP Exporter, and supports
7479
following exporter features:
7580
- `grpc-tonic`: This requires `MeterProvider` to be created within a tokio
@@ -250,11 +255,11 @@ metadata, a feature introduced in version 0.1.40. [#2418](https://github.com/ope
250255
equal signs (`"="`). [#2120](https://github.com/open-telemetry/opentelemetry-rust/pull/2120)
251256

252257
- **Breaking** Introduced `experimental_async_runtime` feature for runtime-specific traits.
253-
- Runtime-specific features (`rt-tokio`, `rt-tokio-current-thread`, and `rt-async-std`)
258+
- Runtime-specific features (`rt-tokio`, `rt-tokio-current-thread`, and `rt-async-std`)
254259
now depend on the `experimental_async_runtime` feature.
255-
- For most users, no action is required. Enabling runtime features such as `rt-tokio`, `rt-tokio-current-thread`,
260+
- For most users, no action is required. Enabling runtime features such as `rt-tokio`, `rt-tokio-current-thread`,
256261
or `rt-async-std` will automatically enable the `experimental_async_runtime` feature.
257-
- If you're implementing a custom runtime, you must explicitly enable the experimental_async_runtime` feature in your
262+
- If you're implementing a custom runtime, you must explicitly enable the experimental_async_runtime` feature in your
258263
Cargo.toml and implement the required `Runtime` traits.
259264

260265
- Removed Metrics Cardinality Limit feature. This was originally introduced in
@@ -263,6 +268,12 @@ hardcoded limit of 2000 and no ability to change it. This feature will be
263268
re-introduced in a future date, along with the ability to change the cardinality
264269
limit.
265270

271+
- *Breaking (Affects custom LogExporter, LogProcessor authors only)*: Rename namespaces
272+
before:
273+
`opentelemetry_sdk::export::logs::{ExportResult, LogBatch, LogExporter};`
274+
now:
275+
`opentelemetry_sdk::logs::{ExportResult, LogBatch, LogExporter};`
276+
266277
## 0.27.1
267278

268279
Released 2024-Nov-27
@@ -271,6 +282,7 @@ Released 2024-Nov-27
271282
- `trace::Config` methods are moving onto `TracerProvider` Builder to be consistent with other signals. See https://github.com/open-telemetry/opentelemetry-rust/pull/2303 for migration guide.
272283
`trace::Config` is scheduled to be removed from public API in `v0.28.0`.
273284
example:
285+
274286
```rust
275287
// old
276288
let tracer_provider: TracerProvider = TracerProvider::builder()
@@ -282,6 +294,7 @@ Released 2024-Nov-27
282294
.with_resource(Resource::empty())
283295
.build();
284296
```
297+
285298
- `logs::LogData` struct is deprecated, and scheduled to be removed from public API in `v0.28.0`.
286299
- Bug fix: Empty Meter names are retained as-is instead of replacing with
287300
"rust.opentelemetry.io/sdk/meter"

opentelemetry-sdk/benches/log_exporter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ use opentelemetry::logs::{LogRecord as _, Logger as _, LoggerProvider as _, Seve
2020
use opentelemetry_sdk::logs::LogResult;
2121

2222
use opentelemetry::InstrumentationScope;
23-
use opentelemetry_sdk::export::logs::LogBatch;
23+
use opentelemetry_sdk::logs::LogBatch;
2424
use opentelemetry_sdk::logs::LogProcessor;
2525
use opentelemetry_sdk::logs::LogRecord;
2626
use opentelemetry_sdk::logs::LoggerProvider;

0 commit comments

Comments
 (0)