Skip to content

Commit 9c46625

Browse files
committed
changed startup wording
1 parent f152a0a commit 9c46625

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

docs/adr/001_error_handling.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ There are various ways to handle errors on trait methods, including swallowing t
1414

1515
## Design Guidance
1616

17-
### 1. Panics are only appropriate at startup
18-
Failures _after_ startup should not panic, instead returning errors to the caller where appropriate, _or_ logging an error if not appropriate.
17+
### 1. No panics from SDK APIs
18+
Failures during regular operation should not panic, instead returning errors to the caller where appropriate, _or_ logging an error if not appropriate.
1919
Some of the opentelemetry SDK interfaces are dictated by the specification in way such that they may not return errors.
2020

2121
### 2. Consolidate error types within a trait where we can, let them diverge when we can't**
@@ -73,7 +73,6 @@ pub type OTelSdkResult = Result<(), OTelSdkError>;
7373
// pub trait LogExporter {
7474
// pub trait SpanExporter {
7575
pub trait PushMetricExporter {
76-
7776
fn export(&self, /* ... */) -> OtelSdkResult;
7877
fn force_flush(&self, /* ... */ ) -> OTelSdkResult;
7978
fn shutdown(&self, /* ... */ ) -> OTelSdkResult;

0 commit comments

Comments
 (0)