Skip to content

Commit b172998

Browse files
authored
Merge branch 'main' into metrcs-sdk-internal-log-overflow
2 parents 7de4eb6 + a736604 commit b172998

File tree

23 files changed

+151
-138
lines changed

23 files changed

+151
-138
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,12 @@ you're more than welcome to participate!
198198
* [Harold Dost](https://github.com/hdost)
199199
* [Julian Tescher](https://github.com/jtescher)
200200
* [Lalit Kumar Bhasin](https://github.com/lalitb)
201+
* [Utkarsh Umesan Pillai](https://github.com/utpilla)
201202
* [Zhongyang Wu](https://github.com/TommyCpp)
202203

203204
### Approvers
204205

205206
* [Shaun Cox](https://github.com/shaun-cox)
206-
* [Utkarsh Umesan Pillai](https://github.com/utpilla)
207207

208208
### Emeritus
209209

examples/metrics-advanced/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
4545
};
4646

4747
// Build exporter using Delta Temporality.
48-
let exporter = opentelemetry_stdout::MetricsExporterBuilder::default()
48+
let exporter = opentelemetry_stdout::MetricExporterBuilder::default()
4949
.with_temporality(Temporality::Delta)
5050
.build();
5151

examples/metrics-basic/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use std::error::Error;
66
use std::vec;
77

88
fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
9-
let exporter = opentelemetry_stdout::MetricsExporterBuilder::default()
9+
let exporter = opentelemetry_stdout::MetricExporterBuilder::default()
1010
// Build exporter using Delta Temporality (Defaults to Temporality::Cumulative)
1111
// .with_temporality(data::Temporality::Delta)
1212
.build();

examples/self-diagnostics/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use opentelemetry::global::{self, set_error_handler, Error as OtelError};
22
use opentelemetry::KeyValue;
33
use opentelemetry_appender_tracing::layer;
4-
use opentelemetry_otlp::{LogExporter, MetricsExporter, WithExportConfig};
4+
use opentelemetry_otlp::{LogExporter, MetricExporter, WithExportConfig};
55
use opentelemetry_sdk::metrics::PeriodicReader;
66
use tracing_subscriber::filter::{EnvFilter, LevelFilter};
77
use tracing_subscriber::fmt;
@@ -109,7 +109,7 @@ fn init_logger_provider() -> opentelemetry_sdk::logs::LoggerProvider {
109109
}
110110

111111
fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
112-
let exporter = MetricsExporter::builder()
112+
let exporter = MetricExporter::builder()
113113
.with_http()
114114
.with_endpoint("http://localhost:4318/v1/metrics")
115115
.build()

opentelemetry-otlp/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ Released 2024-Sep-30
4848
.build()?,
4949
).build();
5050
```
51+
- **Renamed**
52+
- ([#2255](https://github.com/open-telemetry/opentelemetry-rust/pull/2255)): de-pluralize Metric types.
53+
- `MetricsExporter` -> `MetricExporter`
54+
- `MetricsExporterBuilder` -> `MetricExporterBuilder`
5155

5256
## v0.25.0
5357

opentelemetry-otlp/examples/basic-otlp-http/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use opentelemetry::{
77
};
88
use opentelemetry_appender_tracing::layer::OpenTelemetryTracingBridge;
99
use opentelemetry_otlp::WithExportConfig;
10-
use opentelemetry_otlp::{LogExporter, MetricsExporter, Protocol, SpanExporter};
10+
use opentelemetry_otlp::{LogExporter, MetricExporter, Protocol, SpanExporter};
1111
use opentelemetry_sdk::{
1212
logs::LoggerProvider,
1313
metrics::{PeriodicReader, SdkMeterProvider},
@@ -66,7 +66,7 @@ fn init_tracer_provider() -> Result<sdktrace::TracerProvider, TraceError> {
6666
}
6767

6868
fn init_metrics() -> Result<opentelemetry_sdk::metrics::SdkMeterProvider, MetricError> {
69-
let exporter = MetricsExporter::builder()
69+
let exporter = MetricExporter::builder()
7070
.with_http()
7171
.with_protocol(Protocol::HttpBinary) //can be changed to `Protocol::HttpJson` to export in JSON format
7272
.with_endpoint("http://localhost:4318/v1/metrics")

opentelemetry-otlp/examples/basic-otlp/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ SpanEvent #0
120120
### Metric
121121

122122
```text
123-
2024-05-22T20:25:42.908Z info MetricsExporter {"kind": "exporter", "data_type": "metrics", "name": "logging", "resource metrics": 1, "metrics": 1, "data points": 1}
123+
2024-05-22T20:25:42.908Z info MetricExporter {"kind": "exporter", "data_type": "metrics", "name": "logging", "resource metrics": 1, "metrics": 1, "data points": 1}
124124
2024-05-22T20:25:42.908Z info ResourceMetrics #0
125125
Resource SchemaURL:
126126
Resource attributes:

opentelemetry-otlp/examples/basic-otlp/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use opentelemetry::trace::{TraceContextExt, TraceError, Tracer};
55
use opentelemetry::KeyValue;
66
use opentelemetry::{global, InstrumentationScope};
77
use opentelemetry_appender_tracing::layer::OpenTelemetryTracingBridge;
8-
use opentelemetry_otlp::{LogExporter, MetricsExporter, SpanExporter, WithExportConfig};
8+
use opentelemetry_otlp::{LogExporter, MetricExporter, SpanExporter, WithExportConfig};
99
use opentelemetry_sdk::logs::LoggerProvider;
1010
use opentelemetry_sdk::metrics::{PeriodicReader, SdkMeterProvider};
1111
use opentelemetry_sdk::trace::Config;
@@ -34,7 +34,7 @@ fn init_tracer_provider() -> Result<sdktrace::TracerProvider, TraceError> {
3434
}
3535

3636
fn init_metrics() -> Result<opentelemetry_sdk::metrics::SdkMeterProvider, MetricError> {
37-
let exporter = MetricsExporter::builder().with_tonic().build()?;
37+
let exporter = MetricExporter::builder().with_tonic().build()?;
3838

3939
let reader = PeriodicReader::builder(exporter, runtime::Tokio).build();
4040

opentelemetry-otlp/src/exporter/http/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ impl Default for HttpConfig {
8383
///
8484
/// // Create a metrics exporter you can use when configuring meter providers
8585
/// # #[cfg(feature="metrics")]
86-
/// let metrics_exporter = opentelemetry_otlp::MetricsExporter::builder()
86+
/// let metrics_exporter = opentelemetry_otlp::MetricExporter::builder()
8787
/// .with_http()
8888
/// .with_temporality(Temporality::default())
8989
/// .build()?;
@@ -221,7 +221,7 @@ impl HttpExporterBuilder {
221221
pub fn build_metrics_exporter(
222222
mut self,
223223
temporality: opentelemetry_sdk::metrics::data::Temporality,
224-
) -> opentelemetry::metrics::MetricResult<crate::MetricsExporter> {
224+
) -> opentelemetry::metrics::MetricResult<crate::MetricExporter> {
225225
use crate::{
226226
OTEL_EXPORTER_OTLP_METRICS_ENDPOINT, OTEL_EXPORTER_OTLP_METRICS_HEADERS,
227227
OTEL_EXPORTER_OTLP_METRICS_TIMEOUT,
@@ -234,7 +234,7 @@ impl HttpExporterBuilder {
234234
OTEL_EXPORTER_OTLP_METRICS_HEADERS,
235235
)?;
236236

237-
Ok(crate::MetricsExporter::new(client, temporality))
237+
Ok(crate::MetricExporter::new(client, temporality))
238238
}
239239
}
240240

opentelemetry-otlp/src/exporter/tonic/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ impl TryFrom<Compression> for tonic::codec::CompressionEncoding {
9090
///
9191
/// // Create a metric exporter you can use when configuring meter providers
9292
/// # #[cfg(feature="metrics")]
93-
/// let metric_exporter = opentelemetry_otlp::MetricsExporter::builder()
93+
/// let metric_exporter = opentelemetry_otlp::MetricExporter::builder()
9494
/// .with_tonic()
9595
/// .with_temporality(Temporality::default())
9696
/// .build()?;
@@ -274,8 +274,8 @@ impl TonicExporterBuilder {
274274
pub(crate) fn build_metrics_exporter(
275275
self,
276276
temporality: opentelemetry_sdk::metrics::data::Temporality,
277-
) -> opentelemetry::metrics::MetricResult<crate::MetricsExporter> {
278-
use crate::MetricsExporter;
277+
) -> opentelemetry::metrics::MetricResult<crate::MetricExporter> {
278+
use crate::MetricExporter;
279279
use metrics::TonicMetricsClient;
280280

281281
let (channel, interceptor, compression) = self.build_channel(
@@ -287,7 +287,7 @@ impl TonicExporterBuilder {
287287

288288
let client = TonicMetricsClient::new(channel, interceptor, compression);
289289

290-
Ok(MetricsExporter::new(client, temporality))
290+
Ok(MetricExporter::new(client, temporality))
291291
}
292292

293293
/// Build a new tonic span exporter

0 commit comments

Comments
 (0)