chore: made function build_span_flags as private

Author: nikhilmantri0902

opentelemetry-proto/CHANGELOG.md

@@ -3,9 +3,8 @@
 ## vNext
 
 - **Feature**: Add span flags support for `isRemote` property in OTLP trace transformation ([#3153](https://github.com/open-telemetry/opentelemetry-rust/pull/3153))
-  - Implemented `build_span_flags` function that sets OTLP span flags based on parent span's `isRemote` property
-  - Updated span and link transformations to properly set flags field (0x100 for local, 0x300 for remote)
-  - Added comprehensive tests for span flags functionality
+- Updated span and link transformations to properly set flags field (0x100 for local, 0x300 for remote)
+
 - Update proto definitions to v1.7.0.
 - Added Rust generated protos for profiles collector. [#3077](https://github.com/open-telemetry/opentelemetry-rust/pull/3077)
 - **Breaking change**: package opentelemetry_proto::tonic::profiles::v1 renamed to opentelemetry_proto::tonic::profiles::v1development. [#3077](https://github.com/open-telemetry/opentelemetry-rust/pull/3077)

opentelemetry-proto/src/transform/trace.rs

@@ -1,7 +1,7 @@
 #[cfg(feature = "gen-tonic-messages")]
 /// Builds span flags based on the parent span's remote property.
 /// This follows the OTLP specification for span flags.
-pub fn build_span_flags(parent_span_is_remote: bool, base_flags: u32) -> u32 {
+fn build_span_flags(parent_span_is_remote: bool, base_flags: u32) -> u32 {
     use crate::proto::tonic::trace::v1::SpanFlags;
     let mut flags = base_flags;
     flags |= SpanFlags::ContextHasIsRemoteMask as u32;
@@ -54,7 +54,7 @@ pub mod tonic {
                 trace_state: link.span_context.trace_state().header(),
                 attributes: Attributes::from(link.attributes).0,
                 dropped_attributes_count: link.dropped_attributes_count,
-                flags: super::build_span_flags(
+                flags: build_span_flags(
                     link.span_context.is_remote(),
                     link.span_context.trace_flags().to_u8() as u32,
                 ),
@@ -75,7 +75,7 @@ pub mod tonic {
                         vec![]
                     }
                 },
-                flags: super::build_span_flags(
+                flags: build_span_flags(
                     source_span.parent_span_is_remote,
                     source_span.span_context.trace_flags().to_u8() as u32,
                 ),
@@ -137,7 +137,7 @@ pub mod tonic {
                                 vec![]
                             }
                         },
-                        flags: super::build_span_flags(
+                        flags: build_span_flags(
                             source_span.parent_span_is_remote,
                             source_span.span_context.trace_flags().to_u8() as u32,
                         ),
@@ -223,13 +223,13 @@ mod span_flags_tests {
 
     #[test]
     fn test_build_span_flags_local_parent() {
-        let flags = super::build_span_flags(false, 0); // is_remote = false
+        let flags = build_span_flags(false, 0); // is_remote = false
         assert_eq!(flags, SpanFlags::ContextHasIsRemoteMask as u32); // 0x100
     }
 
     #[test]
     fn test_build_span_flags_remote_parent() {
-        let flags = super::build_span_flags(true, 0); // is_remote = true
+        let flags = build_span_flags(true, 0); // is_remote = true
         assert_eq!(
             flags,
             (SpanFlags::ContextHasIsRemoteMask as u32) | (SpanFlags::ContextIsRemoteMask as u32)
@@ -238,13 +238,13 @@ mod span_flags_tests {
 
     #[test]
     fn test_build_span_flags_no_parent() {
-        let flags = super::build_span_flags(false, 0); // no parent = false
+        let flags = build_span_flags(false, 0); // no parent = false
         assert_eq!(flags, SpanFlags::ContextHasIsRemoteMask as u32); // 0x100
     }
 
     #[test]
     fn test_build_span_flags_preserves_base_flags() {
-        let flags = super::build_span_flags(false, 0x01); // SAMPLED flag, local parent
+        let flags = build_span_flags(false, 0x01); // SAMPLED flag, local parent
         assert_eq!(flags, 0x01 | (SpanFlags::ContextHasIsRemoteMask as u32)); // 0x101
     }
 

opentelemetry-sdk/CHANGELOG.md

@@ -3,10 +3,8 @@
 ## vNext
 
 - **Feature**: Add span flags support for `isRemote` property in OTLP exporter ([#3153](https://github.com/open-telemetry/opentelemetry-rust/pull/3153))
-  - Added `parent_span_is_remote` field to `SpanData` to store parent span remote flag
-  - Implemented `build_span_flags` function that sets OTLP span flags based on parent span's `isRemote` property
-  - Updated span and link transformations to properly set flags field (0x100 for local, 0x300 for remote)
-  - Added comprehensive tests for span flags functionality
+- Updated span and link transformations to properly set flags field (0x100 for local, 0x300 for remote)
+
 - TODO: Placeholder for Span processor related things
   - *Fix* SpanProcessor::on_start is no longer called on non recording spans
 - **Fix**: Restore true parallel exports in the async-native `BatchSpanProcessor` by honoring `OTEL_BSP_MAX_CONCURRENT_EXPORTS` ([#2959](https://github.com/open-telemetry/opentelemetry-rust/pull/3028)). A regression in [#2685](https://github.com/open-telemetry/opentelemetry-rust/pull/2685) inadvertently awaited the `export()` future directly in `opentelemetry-sdk/src/trace/span_processor_with_async_runtime.rs` instead of spawning it on the runtime, forcing all exports to run sequentially.