fix doc code

Author: emadpres

opentelemetry-sdk/src/metrics/in_memory_exporter.rs

@@ -28,6 +28,7 @@ type InMemoryMetrics = Vec<ResourceMetrics>;
 /// # Example
 ///
 /// ```
+///# use std::sync::{Arc, Mutex};
 ///# use opentelemetry_sdk::metrics;
 ///# use opentelemetry::{KeyValue};
 ///# use opentelemetry::metrics::MeterProvider;
@@ -36,15 +37,15 @@ type InMemoryMetrics = Vec<ResourceMetrics>;
 ///
 ///# #[tokio::main]
 ///# async fn main() {
-/// // Create an InMemoryMetricExporter
-///  let exporter = InMemoryMetricExporter::builder();
+///  // Create an InMemoryMetricExporter
 ///  let metrics = Arc::new(Mutex::new(Vec::new()));
-///  let exporter = InMemoryMetricExporterBuilder::new()
-///                .with_metrics(metrics.clone()).build();
+///  let exporter = InMemoryMetricExporter::builder()
+///      .with_metrics(metrics.clone())
+///      .build();
 ///
 ///  // Create a MeterProvider and register the exporter
 ///  let meter_provider = metrics::SdkMeterProvider::builder()
-///      .with_reader(PeriodicReader::builder(exporter.clone()).build())
+///      .with_reader(PeriodicReader::builder(exporter).build())
 ///      .build();
 ///
 ///  // Create and record metrics using the MeterProvider
@@ -54,11 +55,8 @@ type InMemoryMetrics = Vec<ResourceMetrics>;
 ///
 ///  meter_provider.force_flush().unwrap();
 ///
-///  // Retrieve the finished metrics from the exporter
-///  let finished_metrics = exporter.get_finished_metrics().unwrap();
-///
 ///  // Print the finished metrics
-/// for resource_metrics in finished_metrics {
+///  for resource_metrics in metrics.lock().unwrap().iter() {
 ///      println!("{:?}", resource_metrics);
 ///  }
 ///# }
@@ -87,12 +85,12 @@ impl fmt::Debug for InMemoryMetricExporter {
 /// # Example
 ///
 /// ```
-/// use opentelemetry_sdk::metrics::{InMemoryMetricExporter, InMemoryMetricExporterBuilder};
-/// use std::sync::{Arc, Mutex};
+///# use opentelemetry_sdk::metrics::{InMemoryMetricExporter, InMemoryMetricExporterBuilder};
+///# use std::sync::{Arc, Mutex};
 ///
 /// let metrics = Arc::new(Mutex::new(Vec::new()));
 /// let exporter = InMemoryMetricExporterBuilder::new()
-///                .with_metrics(metrics.clone()).build();
+///                 .with_metrics(metrics.clone()).build();
 /// ```
 pub struct InMemoryMetricExporterBuilder {
     temporality: Option<Temporality>,
@@ -149,6 +147,7 @@ impl InMemoryMetricExporter {
     ///
     /// ```
     /// use opentelemetry_sdk::metrics::InMemoryMetricExporter;
+    /// use std::sync::{Arc, Mutex};
     ///
     /// let metrics = Arc::new(Mutex::new(Vec::new()));
     /// let exporter = InMemoryMetricExporter::builder()

opentelemetry-sdk/src/metrics/mod.rs

@@ -271,11 +271,7 @@ mod tests {
             test_context.flush_metrics();
 
             // As instrument name are valid because of the feature flag, metrics should be exported
-            let resource_metrics = test_context
-                .exporter
-                .get_finished_metrics()
-                .expect("metrics expected to be exported");
-
+            let resource_metrics = test_context.resource_metrics.lock().unwrap();
             assert!(!resource_metrics.is_empty(), "metrics should be exported");
         }
 
@@ -896,7 +892,9 @@ mod tests {
 
         // Arrange
         let metrics = Arc::new(Mutex::new(Vec::new()));
-        let exporter = InMemoryMetricExporter::builder().with_metrics(metrics.clone()).build();
+        let exporter = InMemoryMetricExporter::builder()
+            .with_metrics(metrics.clone())
+            .build();
 
         let view = |i: &Instrument| {
             if i.name == "test_histogram" {
@@ -950,7 +948,9 @@ mod tests {
 
         // Arrange
         let metrics = Arc::new(Mutex::new(Vec::new()));
-        let exporter = InMemoryMetricExporter::builder().with_metrics(metrics.clone()).build();
+        let exporter = InMemoryMetricExporter::builder()
+            .with_metrics(metrics.clone())
+            .build();
 
         // View drops all attributes.
         let view = |i: &Instrument| {
@@ -1030,7 +1030,9 @@ mod tests {
 
         // Arrange
         let metrics = Arc::new(Mutex::new(Vec::new()));
-        let exporter = InMemoryMetricExporter::builder().with_metrics(metrics.clone()).build();
+        let exporter = InMemoryMetricExporter::builder()
+            .with_metrics(metrics.clone())
+            .build();
 
         // View drops all attributes.
         let view = |i: &Instrument| {

opentelemetry-sdk/src/metrics/periodic_reader_with_async_runtime.rs

@@ -449,7 +449,7 @@ mod tests {
         runtime, Resource,
     };
     use opentelemetry::metrics::MeterProvider;
-    use std::sync::mpsc;
+    use std::sync::{mpsc, Arc, Mutex};
 
     #[test]
     fn collection_triggered_by_interval_tokio_current() {
@@ -493,7 +493,9 @@ mod tests {
     fn unregistered_collect() {
         // Arrange
         let metrics = Arc::new(Mutex::new(Vec::new()));
-        let exporter = InMemoryMetricExporter::builder().with_metrics(metrics.clone()).build();
+        let exporter = InMemoryMetricExporter::builder()
+            .with_metrics(metrics.clone())
+            .build();
 
         let reader = PeriodicReader::builder(exporter, runtime::Tokio).build();
         let mut rm = ResourceMetrics {
@@ -517,7 +519,9 @@ mod tests {
         let interval = std::time::Duration::from_millis(1);
 
         let metrics = Arc::new(Mutex::new(Vec::new()));
-        let exporter = InMemoryMetricExporter::builder().with_metrics(metrics.clone()).build();
+        let exporter = InMemoryMetricExporter::builder()
+            .with_metrics(metrics.clone())
+            .build();
 
         let reader = PeriodicReader::builder(exporter, runtime)
             .with_interval(interval)