TODO for custom connector and executor

Author: lalitb

opentelemetry-http/src/lib.rs

@@ -108,26 +108,34 @@ pub mod hyper {
     use http::HeaderValue;
     use http_body_util::{BodyExt, Full};
     use hyper::body::{Body as HttpBody, Frame};
-    use hyper_util::client::legacy::{connect::HttpConnector, Client};
+    use hyper_util::client::legacy::{
+        connect::{Connect, HttpConnector},
+        Client,
+    };
     use std::fmt::Debug;
     use std::pin::Pin;
     use std::task::{self, Poll};
     use std::time::Duration;
     use tokio::time;
 
     #[derive(Debug, Clone)]
-    pub struct HyperClient {
-        inner: Client<HttpConnector, Body>,
+    pub struct HyperClient<C = HttpConnector>
+    where
+        C: Connect + Clone + Send + Sync + 'static,
+    {
+        inner: Client<C, Body>,
         timeout: Duration,
         authorization: Option<HeaderValue>,
     }
 
-    impl HyperClient {
+    impl<C> HyperClient<C>
+    where
+        C: Connect + Clone + Send + Sync + 'static,
+    {
         /// Creates a new `HyperClient` with default `HttpConnector` and `TokioExecutor`.
-        pub fn new(timeout: Duration, authorization: Option<HeaderValue>) -> Self {
-            let connector = HttpConnector::new();
+        pub fn new(connector: C, timeout: Duration, authorization: Option<HeaderValue>) -> Self {
+            // TODO - support custom executor
             let inner = Client::builder(hyper_util::rt::TokioExecutor::new()).build(connector);
-
             Self {
                 inner,
                 timeout,
@@ -136,6 +144,16 @@ pub mod hyper {
         }
     }
 
+    impl HyperClient<HttpConnector> {
+        /// Creates a new `HyperClient` with a default `HttpConnector`.
+        pub fn with_default_connector(
+            timeout: Duration,
+            authorization: Option<HeaderValue>,
+        ) -> Self {
+            Self::new(HttpConnector::new(), timeout, authorization)
+        }
+    }
+
     #[async_trait]
     impl HttpClient for HyperClient {
         async fn send(&self, request: Request<Vec<u8>>) -> Result<Response<Bytes>, HttpError> {

opentelemetry-otlp/src/exporter/http/mod.rs

@@ -71,6 +71,7 @@ impl Default for HttpConfig {
             not(feature = "reqwest-blocking-client"),
             feature = "hyper-client"
         ))]
+        // TODO - support configuring custom connector and executor
         let default_client = Some(Arc::new(HyperClient::with_default_connector(
             Duration::from_secs(10),
             None,