Skip to content

Commit d09fc52

Browse files
committed
changelog fix
1 parent 40cb477 commit d09fc52

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

opentelemetry-sdk/CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ also modified to suppress telemetry before invoking exporters.
2121
- TODO/Placeholder: Add ability to configure cardinality limits via Instrument
2222
advisory.
2323

24+
- *Breaking* change for custom `MetricReader` authors.
25+
The `shutdown_with_timeout` method is added to `MetricReader` trait.
26+
`collect` method on `MetricReader` modified to return `OTelSdkResult`.
27+
2428
## 0.29.0
2529

2630
Released 2025-Mar-21
@@ -78,7 +82,6 @@ Released 2025-Mar-21
7882
Custom exporters will need to internally synchronize any mutable state, if applicable.
7983

8084
- **Breaking** The `shutdown_with_timeout` method is added to MetricExporter trait. This is breaking change for custom `MetricExporter` authors.
81-
- **Breaking** The `shutdown_with_timeout` method is added to MetricReader trait. This is breaking change for custom `MetricReader` authors.
8285
- Bug Fix: `BatchLogProcessor` now correctly calls `shutdown` on the exporter
8386
when its `shutdown` is invoked.
8487

opentelemetry-sdk/src/testing/metrics/metric_reader.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ use crate::metrics::Temporality;
33
use crate::metrics::{
44
data::ResourceMetrics, pipeline::Pipeline, reader::MetricReader, InstrumentKind,
55
};
6-
use crate::metrics::{MetricResult, Temporality};
76
use std::sync::{Arc, Mutex, Weak};
87
use std::time::Duration;
98

0 commit comments

Comments
 (0)