add default implementation for shutdown_with_timeout in logexporter trait

Author: mohammadVatandoost

opentelemetry-appender-log/Cargo.toml

@@ -29,15 +29,5 @@ spec_unstable_logs_enabled = ["opentelemetry/spec_unstable_logs_enabled"]
 with-serde = ["log/kv_serde", "serde"]
 experimental_metadata_attributes = ["dep:opentelemetry-semantic-conventions"]
 
-[dev-dependencies]
-opentelemetry_sdk = { path = "../opentelemetry-sdk", features = [
-  "testing",
-  "spec_unstable_logs_enabled",
-] }
-opentelemetry-stdout = { workspace = true, features = ["logs"] }
-log = { workspace = true, features = ["kv_serde"] }
-tokio = { workspace = true }
-serde = { workspace = true, features = ["std", "derive"] }
-
 [lints]
 workspace = true

opentelemetry-appender-tracing/Cargo.toml

@@ -20,19 +20,6 @@ tracing-log = { workspace = true, optional = true }
 tracing-subscriber = { workspace = true, features = ["registry", "std"] }
 tracing-opentelemetry = { workspace = true, optional = true }
 
-[dev-dependencies]
-log = { workspace = true }
-opentelemetry-stdout = { workspace = true, features = ["logs"] }
-opentelemetry_sdk = { path = "../opentelemetry-sdk", features = ["logs", "testing"]  }
-tracing = { workspace = true, features = ["std"]}
-tracing-subscriber = { workspace = true, features = ["env-filter","registry", "std", "fmt"] }
-tracing-log = { workspace = true }
-criterion = { workspace = true }
-tokio = { workspace = true, features = ["full"]}
-
-[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
-pprof = { version = "0.14", features = ["flamegraph", "criterion"] }
-
 [features]
 default = []
 experimental_metadata_attributes = ["dep:tracing-log"]

opentelemetry-jaeger-propagator/Cargo.toml

@@ -25,9 +25,6 @@ opentelemetry = { version = "0.29", default-features = false, features = [
     "trace",
 ], path = "../opentelemetry" }
 
-[dev-dependencies]
-opentelemetry = { features = ["testing"], path = "../opentelemetry" }
-
 [features]
 default = ["internal-logs"]
 internal-logs = ["opentelemetry/internal-logs"]

opentelemetry-otlp/Cargo.toml

@@ -43,15 +43,6 @@ serde = { workspace = true, features = ["derive"], optional = true }
 thiserror = { workspace = true }
 serde_json = { workspace = true, optional = true }
 
-[dev-dependencies]
-tokio-stream = { workspace = true, features = ["net"] }
-# need tokio runtime to run smoke tests.
-opentelemetry_sdk = { features = ["trace", "rt-tokio", "testing"], path = "../opentelemetry-sdk" }
-tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }
-futures-util = { workspace = true }
-temp-env = { workspace = true }
-tonic = { workspace = true, features = ["router", "server"] }
-
 [features]
 # telemetry pillars and functions
 trace = ["opentelemetry/trace", "opentelemetry_sdk/trace", "opentelemetry-proto/trace"]

opentelemetry-proto/Cargo.toml

@@ -60,12 +60,5 @@ serde = { workspace = true, optional = true, features = ["serde_derive"] }
 hex = { workspace = true, optional = true }
 base64 = { workspace = true, optional = true }
 
-[dev-dependencies]
-opentelemetry = { features = ["testing"], path = "../opentelemetry" }
-tonic-build = { workspace = true }
-prost-build = { workspace = true }
-tempfile = { workspace = true }
-serde_json = { workspace = true }
-
 [lints]
 workspace = true

opentelemetry-sdk/CHANGELOG.md

@@ -25,7 +25,7 @@ also modified to suppress telemetry before invoking exporters.
   - Fixed the overflow attribute to correctly use the boolean value `true`
     instead of the string `"true"`.
     [#2878](https://github.com/open-telemetry/opentelemetry-rust/issues/2878)
-- *Breaking* The `shutdown_with_timeout` method is added to LogExporter trait. This is breaking change for custom `LogExporter` authors.
+- The `shutdown_with_timeout` method is added to LogExporter trait.
 - *Breaking* `MetricError`, `MetricResult` no longer public (except when
   `spec_unstable_metrics_views` feature flag is enabled). `OTelSdkResult` should
   be used instead, wherever applicable. [#2906](https://github.com/open-telemetry/opentelemetry-rust/pull/2906)

opentelemetry-sdk/Cargo.toml

@@ -31,14 +31,6 @@ http = { workspace = true, optional = true }
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
-[dev-dependencies]
-criterion = { workspace = true, features = ["html_reports"] }
-rstest = { workspace = true }
-temp-env = { workspace = true }
-
-[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
-pprof = { version = "0.14", features = ["flamegraph", "criterion"] }
-
 [features]
 default = ["trace", "metrics", "logs", "internal-logs"]
 trace = ["opentelemetry/trace", "rand", "percent-encoding"]

opentelemetry-sdk/src/logs/export.rs

@@ -136,7 +136,9 @@ pub trait LogExporter: Send + Sync + Debug {
         batch: LogBatch<'_>,
     ) -> impl std::future::Future<Output = OTelSdkResult> + Send;
     /// Shuts down the exporter.
-    fn shutdown_with_timeout(&self, _timeout: time::Duration) -> OTelSdkResult;
+    fn shutdown_with_timeout(&self, _timeout: time::Duration) -> OTelSdkResult {
+        Ok(())
+    }
     /// Shuts down the exporter with a default timeout.
     fn shutdown(&self) -> OTelSdkResult {
         self.shutdown_with_timeout(time::Duration::from_secs(5))

opentelemetry-sdk/src/logs/in_memory_exporter.rs

@@ -215,10 +215,6 @@ impl LogExporter for InMemoryLogExporter {
         Ok(())
     }
 
-    fn shutdown(&self) -> OTelSdkResult {
-        self.shutdown_with_timeout(time::Duration::from_secs(5))
-    }
-
     fn set_resource(&mut self, resource: &Resource) {
         let mut res_guard = self.resource.lock().expect("Resource lock poisoned");
         *res_guard = resource.clone();

opentelemetry-semantic-conventions/Cargo.toml

@@ -24,10 +24,6 @@ rustdoc-args = ["--cfg", "docsrs"]
 default = []
 semconv_experimental = []
 
-[dev-dependencies]
-opentelemetry = { default-features = false, path = "../opentelemetry" } # for doctests
-opentelemetry_sdk = { features = ["trace"], path = "../opentelemetry-sdk" } # for doctests
-
 [lints]
 workspace = true