resource: remove Default fn from pub api

Author: pitoniak32

opentelemetry-proto/src/transform/logs.rs

@@ -252,7 +252,7 @@ mod tests {
 
     #[test]
     fn test_group_logs_by_resource_and_scope_single_scope() {
-        let resource = Resource::default();
+        let resource = Resource::builder().build();
         let (log_record1, instrum_lib1) = create_test_log_data("test-lib", "Log 1");
         let (log_record2, instrum_lib2) = create_test_log_data("test-lib", "Log 2");
 
@@ -273,7 +273,7 @@ mod tests {
 
     #[test]
     fn test_group_logs_by_resource_and_scope_multiple_scopes() {
-        let resource = Resource::default();
+        let resource = Resource::builder().build();
         let (log_record1, instrum_lib1) = create_test_log_data("lib1", "Log 1");
         let (log_record2, instrum_lib2) = create_test_log_data("lib2", "Log 2");
 

opentelemetry-sdk/src/logs/log_emitter.rs

@@ -221,7 +221,7 @@ impl Builder {
 
     /// Create a new provider from this configuration.
     pub fn build(self) -> LoggerProvider {
-        let resource = self.resource.unwrap_or_default();
+        let resource = self.resource.unwrap_or(Resource::builder().build());
 
         let logger_provider = LoggerProvider {
             inner: Arc::new(LoggerProviderInner {

opentelemetry-sdk/src/metrics/meter_provider.rs

@@ -265,7 +265,7 @@ impl MeterProviderBuilder {
         let meter_provider = SdkMeterProvider {
             inner: Arc::new(SdkMeterProviderInner {
                 pipes: Arc::new(Pipelines::new(
-                    self.resource.unwrap_or_default(),
+                    self.resource.unwrap_or(Resource::builder().build()),
                     self.readers,
                     self.views,
                 )),

opentelemetry-sdk/src/metrics/mod.rs

@@ -14,7 +14,7 @@
 //! use opentelemetry_sdk::{metrics::SdkMeterProvider, Resource};
 //!
 //! // Generate SDK configuration, resource, views, etc
-//! let resource = Resource::default(); // default attributes about the current process
+//! let resource = Resource::builder().build(); // default attributes about the current process
 //!
 //! // Create a meter provider with the desired config
 //! let meter_provider = SdkMeterProvider::builder().with_resource(resource).build();

opentelemetry-sdk/src/resource/mod.rs

@@ -51,16 +51,6 @@ pub struct Resource {
     inner: Arc<ResourceInner>,
 }
 
-impl Default for Resource {
-    fn default() -> Self {
-        Self::from_detectors(vec![
-            Box::new(SdkProvidedResourceDetector),
-            Box::new(TelemetryResourceDetector),
-            Box::new(EnvResourceDetector::new()),
-        ])
-    }
-}
-
 impl Resource {
     /// Creates a [ResourceBuilder] Starting from [Resource::default()] that allows you to configure multiple aspects of the Resource.
     ///
@@ -70,7 +60,11 @@ impl Resource {
     /// - [EnvResourceDetector]
     pub fn builder() -> ResourceBuilder {
         ResourceBuilder {
-            resource: Resource::default(),
+            resource: Self::from_detectors(vec![
+                Box::new(SdkProvidedResourceDetector),
+                Box::new(TelemetryResourceDetector),
+                Box::new(EnvResourceDetector::new()),
+            ]),
         }
     }
 

opentelemetry-sdk/src/testing/logs/in_memory_exporter.rs

@@ -121,7 +121,7 @@ impl InMemoryLogExporterBuilder {
     pub fn build(&self) -> InMemoryLogExporter {
         InMemoryLogExporter {
             logs: Arc::new(Mutex::new(Vec::new())),
-            resource: Arc::new(Mutex::new(Resource::default())),
+            resource: Arc::new(Mutex::new(Resource::builder().build())),
             should_reset_on_shutdown: self.reset_on_shutdown,
         }
     }

opentelemetry-sdk/src/testing/trace/in_memory_exporter.rs

@@ -87,7 +87,7 @@ impl InMemorySpanExporterBuilder {
     pub fn build(&self) -> InMemorySpanExporter {
         InMemorySpanExporter {
             spans: Arc::new(Mutex::new(Vec::new())),
-            resource: Arc::new(Mutex::new(Resource::default())),
+            resource: Arc::new(Mutex::new(Resource::builder().build())),
         }
     }
 }

opentelemetry-sdk/src/trace/config.rs

@@ -131,7 +131,7 @@ impl Default for Config {
             sampler: Box::new(Sampler::ParentBased(Box::new(Sampler::AlwaysOn))),
             id_generator: Box::<RandomIdGenerator>::default(),
             span_limits: SpanLimits::default(),
-            resource: Cow::Owned(Resource::default()),
+            resource: Cow::Owned(Resource::builder().build()),
         };
 
         if let Some(max_attributes_per_span) = env::var("OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT")

opentelemetry-stdout/src/logs/exporter.rs

@@ -17,7 +17,7 @@ pub struct LogExporter {
 impl Default for LogExporter {
     fn default() -> Self {
         LogExporter {
-            resource: Resource::default(),
+            resource: Resource::builder().build(),
             is_shutdown: atomic::AtomicBool::new(false),
             resource_emitted: atomic::AtomicBool::new(false),
         }

opentelemetry-stdout/src/trace/exporter.rs

@@ -23,7 +23,7 @@ impl fmt::Debug for SpanExporter {
 impl Default for SpanExporter {
     fn default() -> Self {
         SpanExporter {
-            resource: Resource::default(),
+            resource: Resource::builder().build(),
             is_shutdown: atomic::AtomicBool::new(false),
             resource_emitted: false,
         }