Skip to content

Commit f88d930

Browse files
authored
chore: Prepare for opentelemetry-appender-tracing v0.28.1 (#2653)
1 parent f657b55 commit f88d930

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

opentelemetry-appender-tracing/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
## vNext
44

5+
## 0.28.1
6+
7+
Released 2025-Feb-12
8+
9+
- Bump `tracing-opentelemetry` to 0.29
510
- New experimental feature to use trace\_id & span\_id from spans created through the [tracing](https://crates.io/crates/tracing) crate (experimental_use_tracing_span_context) [#2438](https://github.com/open-telemetry/opentelemetry-rust/pull/2438)
611

712

opentelemetry-appender-tracing/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "opentelemetry-appender-tracing"
3-
version = "0.28.0"
3+
version = "0.28.1"
44
edition = "2021"
55
description = "An OpenTelemetry log appender for the tracing crate"
66
homepage = "https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-appender-tracing"
@@ -17,7 +17,7 @@ tracing = { workspace = true, features = ["std"]}
1717
tracing-core = { workspace = true }
1818
tracing-log = { version = "0.2", optional = true }
1919
tracing-subscriber = { workspace = true, features = ["registry", "std"] }
20-
#tracing-opentelemetry = { version = "0.28", optional = true }
20+
tracing-opentelemetry = { version = "0.29", optional = true }
2121

2222
[dev-dependencies]
2323
log = { workspace = true }
@@ -36,7 +36,7 @@ default = []
3636
experimental_metadata_attributes = ["dep:tracing-log"]
3737
spec_unstable_logs_enabled = ["opentelemetry/spec_unstable_logs_enabled"]
3838
# TODO - Enable this in 0.28.1 (once tracing-opentelemetry v0.29 is released)
39-
#experimental_use_tracing_span_context = ["tracing-opentelemetry"]
39+
experimental_use_tracing_span_context = ["tracing-opentelemetry"]
4040

4141

4242
[[bench]]

opentelemetry-appender-tracing/src/layer.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ where
180180
// Visit fields.
181181
event.record(&mut visitor);
182182

183-
/*#[cfg(feature = "experimental_use_tracing_span_context")]
183+
#[cfg(feature = "experimental_use_tracing_span_context")]
184184
if let Some(span) = _ctx.event_span(event) {
185185
use tracing_opentelemetry::OtelData;
186186
let opt_span_id = span
@@ -198,7 +198,7 @@ where
198198
if let Some((trace_id, span_id)) = opt_trace_id.zip(opt_span_id) {
199199
log_record.set_trace_context(trace_id, span_id, None);
200200
}
201-
} */
201+
}
202202

203203
//emit record
204204
self.logger.emit(log_record);
@@ -516,7 +516,7 @@ mod tests {
516516
}
517517
}
518518

519-
/*#[cfg(feature = "experimental_use_tracing_span_context")]
519+
#[cfg(feature = "experimental_use_tracing_span_context")]
520520
#[test]
521521
fn tracing_appender_inside_tracing_crate_context() {
522522
use opentelemetry_sdk::trace::InMemorySpanExporterBuilder;
@@ -575,7 +575,7 @@ mod tests {
575575
assert_eq!(trace_ctx1.trace_id, trace_id);
576576
assert_eq!(trace_ctx0.span_id, outer_span_id);
577577
assert_eq!(trace_ctx1.span_id, inner_span_id);
578-
}*/
578+
}
579579

580580
#[test]
581581
fn tracing_appender_standalone_with_tracing_log() {

0 commit comments

Comments
 (0)