code comment

cijothomas · cijothomas · commit fbe687a9a591 · 2025-03-12T12:18:18.000-07:00
diff --git a/opentelemetry-appender-tracing/src/layer.rs b/opentelemetry-appender-tracing/src/layer.rs
@@ -114,6 +114,8 @@ impl<LR: LogRecord> tracing::field::Visit for EventVisitor<'_, LR> {
             .add_attribute(Key::new(field.name()), AnyValue::from(value));
     }
 
+    // TODO: We might need to do similar for record_i128,record_u128 too
+    // to avoid stringification, unless needed.
     fn record_u64(&mut self, field: &tracing::field::Field, value: u64) {
         #[cfg(feature = "experimental_metadata_attributes")]
         if is_duplicated_metadata(field.name()) {

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,8 @@ impl<LR: LogRecord> tracing::field::Visit for EventVisitor<'_, LR> {`
`114`	`114`	`.add_attribute(Key::new(field.name()), AnyValue::from(value));`
`115`	`115`	`}`
`116`	`116`
	`117`	`+ // TODO: We might need to do similar for record_i128,record_u128 too`
	`118`	`+ // to avoid stringification, unless needed.`
`117`	`119`	`fn record_u64(&mut self, field: &tracing::field::Field, value: u64) {`
`118`	`120`	`#[cfg(feature = "experimental_metadata_attributes")]`
`119`	`121`	`if is_duplicated_metadata(field.name()) {`