-
Notifications
You must be signed in to change notification settings - Fork 598
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Related Problems?
Hi,
We just migrated Stalwart from opentelemetry 0.25 to 0.29 and noticed two issues that I briefly explained in #2260:
- We use our custom logging backend rather than tracing and
global::set_error_handlerhas been removed. - We also use run own own span, log and metrics export task and the
Defaulttrait has been removed fromSdkLogRecord. In order to be able to generate aSdkLogRecordwe now need to doSdkLoggerProvider::builder().build().logger("stalwart").create_log_record()which is not awful but it would be much nicer ifSdkLogRecord::newwas made public or theDefaulttrait was added.
Describe the solution you'd like:
I propose to:
- Re-implement
global::set_error_handler(or similar) and place it behind a Cargo feature, which will be disabled by default. I agree that most users will usetracing. - Make
SdkLogRecord::newpublic or add theDefaulttrait toSdkLogRecord.
I'm not familiar with the internals of this crate but if you prefer I can submit a PR for these.
Considered Alternatives
No response
Additional Context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request