From 7de4eb60d910e37f479b76a055f05c103ce6e4df Mon Sep 17 00:00:00 2001 From: Lalit Kumar Bhasin Date: Mon, 28 Oct 2024 11:47:08 -0700 Subject: [PATCH 1/2] remove global handler --- opentelemetry-sdk/src/metrics/internal/mod.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/opentelemetry-sdk/src/metrics/internal/mod.rs b/opentelemetry-sdk/src/metrics/internal/mod.rs index 84547d80a6..6c85a0e263 100644 --- a/opentelemetry-sdk/src/metrics/internal/mod.rs +++ b/opentelemetry-sdk/src/metrics/internal/mod.rs @@ -146,7 +146,6 @@ impl, T: Number, O: Operation> ValueMap { let new_tracker = AU::new_atomic_tracker(self.buckets_count); O::update_tracker(&new_tracker, measurement, index); trackers.insert(STREAM_OVERFLOW_ATTRIBUTES.clone(), Arc::new(new_tracker)); - global::handle_error(MetricError::Other("Warning: Maximum data points for metric stream exceeded. Entry added to overflow. Subsequent overflows to same metric until next collect will not be logged.".into())); otel_warn!( name: "ValueMap.measure", message = "Maximum data points for metric stream exceeded. Entry added to overflow. Subsequent overflows to same metric until next collect will not be logged." ); From fcf05d2def64d19d570d2938afb318407bd3b703 Mon Sep 17 00:00:00 2001 From: Lalit Kumar Bhasin Date: Mon, 28 Oct 2024 13:02:39 -0700 Subject: [PATCH 2/2] fix lint error (unused modules) --- opentelemetry-sdk/src/metrics/internal/mod.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/opentelemetry-sdk/src/metrics/internal/mod.rs b/opentelemetry-sdk/src/metrics/internal/mod.rs index 6c85a0e263..6d3b012d1d 100644 --- a/opentelemetry-sdk/src/metrics/internal/mod.rs +++ b/opentelemetry-sdk/src/metrics/internal/mod.rs @@ -16,8 +16,7 @@ use aggregate::is_under_cardinality_limit; pub(crate) use aggregate::{AggregateBuilder, ComputeAggregation, Measure}; pub(crate) use exponential_histogram::{EXPO_MAX_SCALE, EXPO_MIN_SCALE}; use once_cell::sync::Lazy; -use opentelemetry::metrics::MetricError; -use opentelemetry::{global, otel_warn, KeyValue}; +use opentelemetry::{otel_warn, KeyValue}; use crate::metrics::AttributeSet;