Skip to content

Global error handler cleanup - Metrics data-point overflow #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 4 commits into from
Oct 29, 2024
Merged

Global error handler cleanup - Metrics data-point overflow #2259

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7de4eb6
remove global handler
lalitb Oct 28, 2024
b172998
Merge branch 'main' into metrcs-sdk-internal-log-overflow
lalitb Oct 28, 2024
fcf05d2
fix lint error (unused modules)
lalitb Oct 28, 2024
23a661b
Merge branch 'main' into metrcs-sdk-internal-log-overflow
cijothomas Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions opentelemetry-sdk/src/metrics/internal/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ use aggregate::is_under_cardinality_limit;
pub(crate) use aggregate::{AggregateBuilder, ComputeAggregation, Measure};
pub(crate) use exponential_histogram::{EXPO_MAX_SCALE, EXPO_MIN_SCALE};
use once_cell::sync::Lazy;
use opentelemetry::metrics::MetricError;
use opentelemetry::{global, otel_warn, KeyValue};
use opentelemetry::{otel_warn, KeyValue};

use crate::metrics::AttributeSet;

Expand Down Expand Up @@ -146,7 +145,6 @@ impl<AU: AtomicallyUpdate<T>, T: Number, O: Operation> ValueMap<AU, T, O> {
let new_tracker = AU::new_atomic_tracker(self.buckets_count);
O::update_tracker(&new_tracker, measurement, index);
trackers.insert(STREAM_OVERFLOW_ATTRIBUTES.clone(), Arc::new(new_tracker));
global::handle_error(MetricError::Other("Warning: Maximum data points for metric stream exceeded. Entry added to overflow. Subsequent overflows to same metric until next collect will not be logged.".into()));
otel_warn!( name: "ValueMap.measure",
Copy link
Member

@cijothomas cijothomas Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name "ValueMap.measure" is not meaningful for end users.

message = "Maximum data points for metric stream exceeded. Entry added to overflow. Subsequent overflows to same metric until next collect will not be logged."
);
Expand Down
Loading