Skip to content

[Metrics] Remove unnecessary box #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 2 commits into from
Dec 3, 2024
Merged

[Metrics] Remove unnecessary box #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
681dbac
Remove unnecessary box
utpilla Dec 3, 2024
ae29664
Merge branch 'main' into utpilla/Remove-unnecessary-box
cijothomas Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opentelemetry-sdk/src/metrics/manual_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
/// # drop(reader)
/// ```
pub struct ManualReader {
inner: Box<Mutex<ManualReaderInner>>,
inner: Mutex<ManualReaderInner>,
temporality: Temporality,
}

Expand Down Expand Up @@ -58,10 +58,10 @@
/// A [MetricReader] which is directly called to collect metrics.
pub(crate) fn new(temporality: Temporality) -> Self {
ManualReader {
inner: Box::new(Mutex::new(ManualReaderInner {
inner: Mutex::new(ManualReaderInner {

Check warning on line 61 in opentelemetry-sdk/src/metrics/manual_reader.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-sdk/src/metrics/manual_reader.rs#L61 

Added line #L61 was not covered by tests
sdk_producer: None,
is_shutdown: false,
})),
}),

Check warning on line 64 in opentelemetry-sdk/src/metrics/manual_reader.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-sdk/src/metrics/manual_reader.rs#L64 

Added line #L64 was not covered by tests
temporality,
}
}
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/metrics/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub struct Pipeline {
pub(crate) resource: Resource,
reader: Box<dyn MetricReader>,
views: Vec<Arc<dyn View>>,
inner: Box<Mutex<PipelineInner>>,
inner: Mutex<PipelineInner>,
}

impl fmt::Debug for Pipeline {
Expand Down
Loading