Skip to content

Conversation

@ttys3
Copy link
Contributor

@ttys3 ttys3 commented Dec 5, 2024

Changes

make opentelemetry-prometheus compatible with opentelemetry 0.27

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ttys3 ttys3 requested a review from a team as a code owner December 5, 2024 11:58
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (957659f) to head (29279ca).

Files with missing lines Patch % Lines
opentelemetry-prometheus/src/lib.rs 76.4% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2385   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        123     123           
  Lines      21479   21479           
=====================================
+ Hits       17064   17068    +4     
+ Misses      4415    4411    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ttys3
Copy link
Contributor Author

ttys3 commented Dec 5, 2024

the CI failure seems not related to my PR

error: unexpected cfg condition value: internal-logs

ref rust-lang/rust#125368
rust-lang/rust#131376

@ttys3 ttys3 changed the title fix: fix opentelemetry-prometheus compatibility with opentelemetry 0.27 refactor: make opentelemetry-prometheus compatibility with opentelemetry 0.27 Dec 5, 2024
@ttys3 ttys3 changed the title refactor: make opentelemetry-prometheus compatibility with opentelemetry 0.27 chore: make opentelemetry-prometheus compatibility with opentelemetry 0.27 Dec 5, 2024
@ttys3 ttys3 force-pushed the opentelemetry-prometheus-sdk-0.27 branch 2 times, most recently from d534e1a to 8bc7467 Compare December 5, 2024 14:46
@ttys3 ttys3 force-pushed the opentelemetry-prometheus-sdk-0.27 branch from 8bc7467 to 29279ca Compare December 5, 2024 14:47
@ttys3
Copy link
Contributor Author

ttys3 commented Dec 5, 2024

close due to duplicated with #2309

@ttys3 ttys3 closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant