Skip to content

fix: missing thiserror crate when building with --no-default-features #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weichweich wants to merge 1 commit into from
+2 −2
Closed

fix: missing thiserror crate when building with --no-default-features #2408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opentelemetry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ rustdoc-args = ["--cfg", "docsrs"]
futures-core = { workspace = true, optional = true }
futures-sink = { version = "0.3", optional = true }
pin-project-lite = { workspace = true, optional = true }
thiserror = { workspace = true, optional = true}
thiserror = { workspace = true }
Copy link
Member

@lalitb lalitb Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep optional dependency on thiserror. As of now, it is supposed to be used only when trace feature flag is enabled. If that is not the case, we should fix it.

Copy link
Author

@weichweich weichweich Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thiserror is used in opentelemetry::propagation. So it should be removed from there?

Copy link
Member

@lalitb lalitb Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propagators are only used in the context of traces. See if we can include it only if trace flag is enabled here -

opentelemetry-rust/opentelemetry/src/lib.rs

Line 267 in 2573773

pub mod propagation;

Copy link
Member

@lalitb lalitb Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also, you need to sign the CLA in order for this to be merged :)

Copy link
Author

@weichweich weichweich Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's fine for you I would prefer to not sign the CLA and leave the fix to you? 😅 Thanks for getting back so quickly!

Copy link
Member

@lalitb lalitb Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks for the issue :)

tracing = {workspace = true, optional = true} # optional for opentelemetry internal logging

[target.'cfg(all(target_arch = "wasm32", not(target_os = "wasi")))'.dependencies]
js-sys = "0.3.63"

[features]
default = ["trace", "metrics", "logs", "internal-logs"]
trace = ["pin-project-lite", "futures-sink", "futures-core", "thiserror"]
trace = ["pin-project-lite", "futures-sink", "futures-core"]
metrics = []
testing = ["trace", "metrics"]
logs = []
Expand Down
Loading