-
Notifications
You must be signed in to change notification settings - Fork 599
Update CHANGELOGs for time changes in metrics aggregations #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOGs for time changes in metrics aggregations #2412
Conversation
|
It's worth noting, that currently #2411 is not closed yet, even though it's mentioned in CHANGELOG already. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 122 122
Lines 21569 21569
=====================================
Hits 17114 17114
Misses 4455 4455 ☔ View full report in Codecov by Sentry. |
|
|
||
| ## vNext | ||
|
|
||
| - *Breaking* time fields, `StartTime` and `EndTime` is printed on aggregation (Sum, Gauge, Histogram, ExpoHistogram) with 2 tabs, previously it was on aggregation data point, with 3 tabs, see [#2377](https://github.com/open-telemetry/opentelemetry-rust/pull/2377) and [#2411](https://github.com/open-telemetry/opentelemetry-rust/pull/2411). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay to skipp changelog for stdout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to mention this... I mean, my company use similar approach in production (have custom exporter that exports metrics as logs using log instead println). So I imagine that someone might rely on the format of stdout exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I imagine that someone might rely on the format of stdout exporter.
I don't think so. It's explicitly called out that stdout is only for learning purposes, and its output format should not be relied upon for anything.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-stdout/src/lib.rs#L1-L4
(Not a blocker for this PR, just sharing that stdout is not meant for that purpose)
point out that this is for exporter authors only Co-authored-by: Cijo Thomas <[email protected]>
Changes
Update
CHANGELOGinsdkandstdoutcrates, to reflect breaking changes made on metric aggregations.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes