Skip to content

Set pwd for precommit.sh script to support running it in any directory #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Set pwd for precommit.sh script to support running it in any directory #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e64da4
Set pwd for precommit to support run it in any directory
ThomsonTan Jan 22, 2025
956b7f0
Merge branch 'main' into set_precommit_pwd
cijothomas Jan 23, 2025
b21bd3f
Merge branch 'main' into set_precommit_pwd
lalitb Jan 24, 2025
4240837
Merge branch 'main' into set_precommit_pwd
cijothomas Feb 7, 2025
d568100
modify contributing
cijothomas Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ Open a pull request against the main
repo.

> **Note**
> It is recommended to run [pre-commit script](scripts/precommit.sh) from the root of
the repo to catch any issues locally.
> It is recommended to run [pre-commit script](scripts/precommit.sh) to catch any issues locally.

### How to Receive Comments

Expand Down
8 changes: 7 additions & 1 deletion scripts/precommit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
cargo update && cargo fmt --all && ./scripts/lint.sh && ./scripts/test.sh
REPO_ROOT=$(dirname $( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ))

pushd "${REPO_ROOT}" > /dev/null

cargo update && cargo fmt --all && ./scripts/lint.sh && ./scripts/test.sh

popd > /dev/null