Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Jan 31, 2025

Add few more tests to metrics.
Tokio::Current is failing, will investigate that separately. -- This is fixed.#2583 (comment)

@cijothomas cijothomas requested a review from a team as a code owner January 31, 2025 21:05
@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (a1860eb) to head (7e66a54).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2582   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        118     118           
  Lines      22490   22490           
=====================================
  Hits       17888   17888           
  Misses      4602    4602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

@lalitb Did some refactoring. In a follow up, I plan to split the metrics test into two - one testing the full payload, and another one just checking presence of the guid. The latter one is where I plan to add all testing permutations (tokio vs other vs etc...)

@lalitb
Copy link
Member

lalitb commented Feb 2, 2025

@cijothomas Seems tokio current test is still failing. If so, should we keep it ignored, and add as separate PR., to unblock this?

@cijothomas
Copy link
Member Author

@cijothomas Seems tokio current test is still failing. If so, should we keep it ignored, and add as separate PR., to unblock this?

It is expected to pass. There seems to be occasional instability in the test, not related to tokio::current, but the general tension of running things in parallel. We'll need to make it more robust in future.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cijothomas cijothomas merged commit 3fc8485 into open-telemetry:main Feb 3, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-integration-test branch February 3, 2025 14:54
scottgerring pushed a commit to scottgerring/opentelemetry-rust that referenced this pull request Feb 5, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants