-
Notifications
You must be signed in to change notification settings - Fork 600
Add more metric integration tests #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more metric integration tests #2582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2582 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 118 118
Lines 22490 22490
=====================================
Hits 17888 17888
Misses 4602 4602 ☔ View full report in Codecov by Sentry. |
|
@lalitb Did some refactoring. In a follow up, I plan to split the metrics test into two - one testing the full payload, and another one just checking presence of the guid. The latter one is where I plan to add all testing permutations (tokio vs other vs etc...) |
|
@cijothomas Seems tokio current test is still failing. If so, should we keep it ignored, and add as separate PR., to unblock this? |
It is expected to pass. There seems to be occasional instability in the test, not related to tokio::current, but the general tension of running things in parallel. We'll need to make it more robust in future. |
lalitb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Add few more tests to metrics.
Tokio::Current is failing, will investigate that separately. -- This is fixed.#2583 (comment)